GithubHelp home page GithubHelp logo

Comments (4)

NtTestAlert avatar NtTestAlert commented on July 27, 2024 1

#596 it's not events array. Its namespace delimiter.

Indeed, but currently it is impossible to react to multiple events, because using multiple @OnEvent on a single method overwrites the decorator metadata.
One would need to either create a separate wrapper method for every event type (which would become unmaintainable with many events or dynamic arrays), or use EventEmitter2 directly (which defeats the purpose of the library).

Instead the decorator metadata could be implemented in a way that handled that gracefully.
nestjs/common contains a helper method, extendArrayMetadata (present since before 7.0.0) that would do it, while there is no decorator version of that method like SetMetadata that's trivial.

Not always will events that we want to handle conform to something that can be solved with wildcards

Posting a PR momentarily.

from event-emitter.

Maligosus avatar Maligosus commented on July 27, 2024

#596 it's not events array. Its namespace delimiter.

from event-emitter.

pklaschka avatar pklaschka commented on July 27, 2024

I generally speaking hate "+1" comments, but quickly wanted to say that this capability would significantly improve my developer experience with this library.

I don't have a strong opinion about multiple OnEvent() vs a single OnEvents() decorator (although I will say that it just took me some time trying to figure out that my intuitive attempt of using multiple OnEvent() decorators wasn't supported, so if that continues to be unsupported, clear documentation about this would be great), but if one of these options gets added to this library, that will make my day (on whatever day it gets released) 😉 (and enable much cleaner code for these kinds of scenarios).

For now, I'm glad to have found at least a working solution (thanks, @NtTestAlert , for sharing that workaround), but I would greatly appreciate not having to explicitly inject the event emitter into my services just for that.

from event-emitter.

kamilmysliwiec avatar kamilmysliwiec commented on July 27, 2024

Let's track this here #657

from event-emitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.