Comments (4)
Indeed, but currently it is impossible to react to multiple events, because using multiple @OnEvent
on a single method overwrites the decorator metadata.
One would need to either create a separate wrapper method for every event type (which would become unmaintainable with many events or dynamic arrays), or use EventEmitter2 directly (which defeats the purpose of the library).
Instead the decorator metadata could be implemented in a way that handled that gracefully.
nestjs/common contains a helper method, extendArrayMetadata
(present since before 7.0.0) that would do it, while there is no decorator version of that method like SetMetadata
that's trivial.
Not always will events that we want to handle conform to something that can be solved with wildcards
Posting a PR momentarily.
from event-emitter.
#596 it's not events array. Its namespace delimiter.
from event-emitter.
I generally speaking hate "+1" comments, but quickly wanted to say that this capability would significantly improve my developer experience with this library.
I don't have a strong opinion about multiple OnEvent()
vs a single OnEvents()
decorator (although I will say that it just took me some time trying to figure out that my intuitive attempt of using multiple OnEvent()
decorators wasn't supported, so if that continues to be unsupported, clear documentation about this would be great), but if one of these options gets added to this library, that will make my day (on whatever day it gets released) 😉 (and enable much cleaner code for these kinds of scenarios).
For now, I'm glad to have found at least a working solution (thanks, @NtTestAlert , for sharing that workaround), but I would greatly appreciate not having to explicitly inject the event emitter into my services just for that.
from event-emitter.
Let's track this here #657
from event-emitter.
Related Issues (20)
- EventEmitterModule crash with TypeError from reflect-metadata stack when used with Proxy HOT 1
- Mitigating Event Loss Risk During NestJS Application Initialization HOT 2
- Event Emitter Exception Logging HOT 1
- Add the ability to catch errors from event listeners via ExceptionFilters HOT 2
- Event listeners are registered twice HOT 4
- @OnEvent decorators is not working when applied multiple times on same method HOT 2
- Duplicate events when using useExisting providers HOT 3
- OnEvent decorator does not triggered if list of events provided HOT 4
- EventEmitterModuleOptions maxListeners setting isn't applied HOT 3
- Exceptions in async event handlers make the app crash HOT 1
- Custom event decorators break with the latest array metadata type requirement HOT 2
- Jest Unit tests only emit events when intializing full AppModule HOT 8
- Provider EventEmitter can't not resolve when using TerserPlugin webpack HOT 3
- Using event emitter in imported npm package cannot resolve emitter HOT 3
- async function constructor name not AsyncFunction HOT 1
- Upgrade to use event emitter 3, or add an option for it HOT 1
- Suppressing errors when updating from 2.0.0 to 2.0.1 HOT 1
- Option to throw error if an event fails to process HOT 3
- Add OnSafeEvent HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from event-emitter.