GithubHelp home page GithubHelp logo

Comments (3)

lucassith avatar lucassith commented on April 28, 2024 1

Please ignore my dummy code, I get that registering routes this way:

  const server = app.getHttpAdapter();
  server.use('/test', (req, res) => {
    res.send(`test ${new Date().toISOString()}`);
  });

is wrong.

But please note that NestJS packges are using this way to register GraphQLModule in @nestjs/graphql and it allows everyone to query your entire database without any authorization, even though you have global guards registered.

https://github.com/nestjs/graphql/blob/c2e408f37c2842ba9c9df90bbd8cd80bd0cb3779/packages/apollo/lib/drivers/apollo-base.driver.ts#L139

from nest.

micalevisk avatar micalevisk commented on April 28, 2024 1

to me, that's not wrong. It's a good way to slowly migrate an express/fastify app to nestjs, I guess

but yeah, not sure if that is a missing feature or a bug

from nest.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

This is the expected behavior. Any routes registered directly with the HttpServerAdapter are not wrapped with guards, interceptors, pipes, etc.

from nest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.