Comments (6)
@tolgap it shouldn't matter, but it was abused :-(
I suggest a diffrent thing:
export enum RpcParamtype {
PAYLOAD = RouteParamtypes.BODY,
CONTEXT = RouteParamtypes.HEADERS,
GRPC_CALL = RouteParamtypes.FILES,
}
Working on a PR now.
from nest.
cc @tolgap 👀
from nest.
Same issue for RPC. RpcParamtype.CONTEXT
value 6 used to be mapped to RouteParamtypes.HEADERS
which was mapped to custom
in ParamsTokenFactory
. Now it is mapped to RouteParamtypes.PARAM
.
The mentioned commit did introduce this regression but I think the issue here is not related to it, but to the fact that there is some sort of dependency between enum values across the packages which is not correct, and not enforced correctly. @kamilmysliwiec thoughts?
from nest.
The type coercion here is the culprit
nest/packages/core/pipes/pipes-consumer.ts
Lines 13 to 15 in df37ea1
from nest.
Wasn't aware that the position was this important for this. @kamilmysliwiec do we revert in the meantime then come back to this?
from nest.
@tolgap opened #13351 this should revert to the original behavior
from nest.
Related Issues (20)
- Wrong type (as in #12264) HOT 3
- Nest CLI generates the wrong package.json file HOT 8
- Watch mode is broken HOT 1
- Hyphens in parameters silently fail HOT 4
- Improve documentation on @Injectable() HOT 2
- Log is not auto-flushed on error during initialization HOT 1
- Middleware not executed when using `exclude` in `setGlobalPrefix` HOT 2
- The use of SetMetadata custom decorators does not take effect HOT 13
- NestJS HttpException class returns success status when status is undefined HOT 4
- NestJs DI `useFactory` ignores property dependencies HOT 1
- I can't use two kafka client in one nest.js server to consume other topics. HOT 1
- Support using `@Inject()` decorator factory with no args on constructor-based injections
- Add CLI options to make the testing, linting, and formatting configurations optional. HOT 1
- @nestjs/microservices: RabbitMQ connection options not passed to amqp-connection-manager HOT 2
- 我有一个问题,关于依赖注入和模块导入的 HOT 1
- [chore] drop dev. dependencies that are leading to errors on running `npm install` in this repo HOT 6
- Support for Multiple HTTP Methods on the function HOT 3
- Cannot read properties of undefined (reading 'constructor') HOT 3
- Nest can't resolve dependencies of the DiscoveryService (?). Please make sure that the argument ModulesContainer at index [0] HOT 11
- I have a question about dependency injection and module import HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.