Comments (4)
@alexjoverm fe:
from: instance-loader.ts
private callModuleInitHook(module: Module) {
const components = [...module.routes, ...module.components];
components.map(([key, {instance}]) => instance)
.filter((instance) => !isNil(instance))
.filter(this.hasOnModuleInitHook)
.forEach((instance) => (instance as OnModuleInit).onModuleInit());
}
Depends on how many components are, this chain will be executed 4 times for N items.
So when we will use iterare:
private callModuleInitHook(module: Module) {
const components = [...module.routes, ...module.components];
iterate(components).map(([key, {instance}]) => instance)
.filter((instance) => !isNil(instance))
.filter(this.hasOnModuleInitHook)
.forEach((instance) => (instance as OnModuleInit).onModuleInit());
}
Will only loop just once for N items. Slightly performance improvements. Bechmarks http://iterare.surge.sh/#performance shows the impact.
Regards.
from nest.
Hi @cojack,
Since 2.0.0 iterate library is used. Thanks for your proposal :)
from nest.
I don't understand this issue. Cannot one itself use iterate on its code? Is this issue meaning to use iterate in the core code of nest?
from nest.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from nest.
Related Issues (20)
- Jest fails to import files HOT 7
- Type instantiation is excessively deep and possibly infinite HOT 3
- Route Handler Fails to Reflect Middleware Modifications to `request.originalUrl` for API Versioning
- cannot run debugger with custom webpack config HOT 1
- Extended ConsoleLogger prints undefined on every log message HOT 2
- Argument of type 'FastifyCookie' is not assignable to parameter of type 'FastifyPluginCallback<FastifyCookieOptions> | FastifyPluginAsync<FastifyCookieOptions> | Promise<...> | Promise<...>'. HOT 2
- Kafka microservice throw Error when first connect to server HOT 1
- Decouple Nest's DI container from Node API HOT 5
- KafkaJs seems not maintained anymore HOT 5
- Add `@RawBody()` decorator to avoid having to always resort to `@Req()` with specific types and parameters HOT 1
- Nest can't resolve dependencies of the custom Validator with Repository HOT 2
- issue opened on wrong repo HOT 1
- Bad typings for Fastify server `enableCors` method, `delegator` property is missing HOT 3
- When I use Nestjs in my own build monorepo project, there seems to be some bugs with "@nestjs/core postinstall". HOT 1
- Improve experience when initialisation error occurs HOT 1
- When I introduce a configuration file from outside the project, an error occurs: Cannot find module HOT 3
- circular dependecy error due to reflect-metadata dependency HOT 1
- Validation Pipe is not executed HOT 2
- Error cause is not logged in dev:watch mode
- Use multiple env files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.