GithubHelp home page GithubHelp logo

Comments (9)

neilime avatar neilime commented on April 26, 2024 1

I've tried to use fastify as explained in https://docs.nestjs.com/techniques/performance, wihout success :

Always get an error "[PackageLoader] The "fastify" package is missing. Please, make sure to install this library ($ npm install fastify) to take advantage of FastifyAdapter."

Even if I manually load fastify package in main.ts. Examples:

  • const fastify = require('fastify');
  • import fastify from 'fastify';
  • ...

Maybe it will be usefull to be able to pass the fastify instance to the adapter :

const fastify = require('fastify');

enableProdMode();

async function bootstrap() {
  const app = await NestFactory.create(ApplicationModule, new FastifyAdapter({
    instance: fastify
  }));
  app.enableCors({
    methods: 'GET',
    maxAge: 3600,
  });
  await app.listen(4000);
}
bootstrap().catch(err => console.error(err));

from ng-universal.

darita92 avatar darita92 commented on April 26, 2024

Anyone has been able to do this, I am still getting this error.

from ng-universal.

MichiNetlight avatar MichiNetlight commented on April 26, 2024

Will fastify support be an option in the future?

from ng-universal.

Sikora00 avatar Sikora00 commented on April 26, 2024

@kamilmysliwiec I can push it further and try to create a pull request after the answer in angular/universal#1871

from ng-universal.

kamilmysliwiec avatar kamilmysliwiec commented on April 26, 2024

@Sikora00 sounds great!

from ng-universal.

Sikora00 avatar Sikora00 commented on April 26, 2024

@kamilmysliwiec things get complicated angular/universal#1892
It looks like the angular universal won't support fastify by themselves. One plus is that there is already a working solution in this pull request. The question is if you are good with using that solution, where this should be stored (what organization on github and who will maintain it).
For now, I think there is only an option to create a new (@nestjs|trilon)/fastify-engine or I can declare that we can create and maintain it with @valueadd-poland

from ng-universal.

kamilmysliwiec avatar kamilmysliwiec commented on April 26, 2024

I can declare that we can create and maintain it with @valueadd-poland

If you have some time, that would be great! Feel free to fork this repository (+ ping users here once it's available - if you want). Since Angular doesn't plan to publish this under the official organization account, we won't be doing this either.

from ng-universal.

invaderb avatar invaderb commented on April 26, 2024

@Sikora00
Have you started this process yet? ng-universal has opened the common engine api to be consumed as needed

from ng-universal.

Sikora00 avatar Sikora00 commented on April 26, 2024

@invaderb no I haven't. I don't think I could handle maintenance by myself.

from ng-universal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.