Comments (12)
You're absolutely right! Thank you for pointing me at this issue :) Fixed in 5.0.2
from passport.
I think the problem is that when you put an unknown strategy into AuthGuard (e.g. @UseGuards(AuthGuard('whatever'))
) it won't complain.
from passport.
Hi. Was this really fixed? I have followed the guide and got the same error, I am using Nest 5.8.0.
from passport.
Maybe something like this:
const createPassportContext = (request, response) => (type, options, callback) => new Promise((resolve, reject) => {
const next = (value) => {
console.log('here we go', value);
return value instanceof Error ? reject(value) : resolve(value);
}
return passport.authenticate(type, options, (err, user, info) => {
try {
request.authInfo = info;
return resolve(callback(err, user, info));
}
catch (err) {
reject(err);
}
})(request, response, next)
});
When I do this I get a 500 error, that make much more sense...
from passport.
Please, provide a repository which reproduces your issue.
And resolve
has to be used, it's not an issue.
from passport.
Simply follow this tutorial https://docs.nestjs.com/techniques/authentication step by step :-D
from passport.
but actually, you can also try there https://github.com/apiel/wudo
cd backend && yarn && yarn start
You will get the response [1234] when you should not be authorize
from passport.
I just pulled your repo and everything works well. I'm getting 401 when the token is not passed through the network, same as expected.
from passport.
Yes because in the mid-time, I have been working on it... As @DEX3 described, change @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) you will then get no error and have access to the entry point.
Also, can you explain me why you are resolving error? Shouldn't error be rejected in a promise?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise#Parameters
executor
A function that is passed with the arguments resolve and reject. The executor function is executed immediately by the Promise implementation, passing resolve and reject functions (the executor is called before the Promise constructor even returns the created object). The resolve and reject functions, when called, resolve or reject the promise, respectively. The executor normally initiates some asynchronous work, and then, once that completes, either calls the resolve function to resolve the promise or else rejects it if an error occurred. If an error is thrown in the executor function, the promise is rejected. The return value of the executor is ignored.
from passport.
change @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) you will then get no error and have access to the entry point
The responsibility for checking whether a strategy exists belongs to passport library (that's why we cannot detect it earlier).
Also, can you explain me why you are resolving error? Shouldn't error be rejected in a promise?
Because the resolved value is eventually passed to the handleRequest
method anyway. See:
Line 62 in e9d1766
from passport.
If I remember correctly, resolve(new error...) is called before handleRequest and handleRequest is not called. You should really try to replace @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) , you will understand.
from passport.
Close it ;)
from passport.
Related Issues (20)
- passport-steam Guide will be appreciated HOT 1
- How about changing the constructor parameter type of PassportStrategy like this? HOT 1
- validate(payload: any) in Implementing Passport JWT doc it's not correct HOT 2
- AuthGuard on Local Strategy return undefinded HOT 1
- overwhelmed by error logs HOT 6
- Pretty magical thing: request.authInfo = undefined and behavior is very strange HOT 3
- Unable to preserve session in passport v0.6.0 HOT 2
- v10 does not allow typing on custom `getRequest` method in class with extended AuthGuard HOT 1
- AuthGuard does not work with authentication-only strategies HOT 1
- Support for [email protected] HOT 3
- using @Inject(REQUEST) req breaks passport. HOT 4
- Guard Order Scope affects order of execution HOT 2
- Can a new release be pushed? HOT 3
- Nest can't resolve dependencies of the JwtAuthenticationGuard after upgrade 8.1.0 to 8.1.1 HOT 9
- Cannot read properties of undefined (reading 'property') HOT 1
- Using custom passport from a different package causes error HOT 1
- Dependency tree discrepancy HOT 2
- PassportStrategy interface does not contain validate() HOT 2
- The defaultStrategies cannot be set during runtime in the AuthGuard HOT 1
- Typing of the result of getAuthenticateOptions is misleading/incorrect HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from passport.