[Bug] Error: [object Object] using AuthGuard with GraphQL about passport

[kamilmysliwiec]

This isn't AuthGuard issue. I did a small research and it seems that this is how apollo serializes thrown error. If you throw "Test", it would print the following output:

Error: Test

Whilst message property of the HttpException is an object. Regardless of this weird console output, the GraphQL response looks perfectly fine:

[kamilmysliwiec]

Duplicate of #4 🙂

[cdiaz]

They are different bugs.
I've updated to version v1.0.9 and this still persists.

[kamilmysliwiec]

Please, make sure to get rid of internal @nestjs/common package installed by @nestjs/passport (full path: node_modules/@nestjs/passport/node_modules/@nestjs/common)

[cdiaz]

node_modules/@nestjs/passport/node_modules/@nestjs/common is not present, and still the error keeps appearing

[ph55]

Okay.

But in general, if framework handled exception and proper response returned -
why it should be displayed in console ?

I mean, exception usually means something wrong happened in your application - and you want to crash it.

Don't you agree, @kamilmysliwiec ?

[kamilmysliwiec]

This output comes from the Apollo server @ph55

[ph55]

I understand that.

But, you have power of suppressing such errors when wrapping it, don't you? Or am I wrong.
It's just question of design.

[kamilmysliwiec]

@ph55, yeah, you have, using formatError option from Apollo. It has nothing to do with Nest.

[ph55]

I don't think formatError helps much.
I'll explain in another example.

User authentication service:

    const AuthenticationError = createError('AuthenticationError', {
      message: 'Username or password are incorrect'
    });

    if (!match) {
      throw new AuthenticationError();
    }

Using format error gives me desired result in output:

{
	"data": {
		"login": null
	},
	"errors": [
		{
			"message": "Username or password are incorrect",
			"name": "AuthenticationError",
			"time_thrown": "2018-06-24T13:47:39.214Z",
			"data": {}
		}
	]
}

But error still thrown in console:

[Nest] 4060   - 2018-6-24 16:47:37   [NestApplication] Nest application successfully started +30ms
AuthenticationError: Username or password are incorrect
    at UserService.<anonymous> (C:\Users\alex\Documents\_dev\nest-apps\src\@core\user\user.service.ts:51:13)
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\alex\Documents\_dev\nest-apps\src\@core\user\user.service.ts:16:58)
    at <anonymous>

So the questions are:

1. Why its still thrown.
2. How to suppress it.
3. Am I stupid ?

[ph55]

It's apollo-server config.
apollographql/apollo-server#894

Thanks for help.

[cojack]

Any progress?