GithubHelp home page GithubHelp logo

Comments (10)

kamilmysliwiec avatar kamilmysliwiec commented on April 26, 2024

https://github.com/node-cron/node-cron#allowed-values

from schedule.

kb05 avatar kb05 commented on April 26, 2024

Hi @kamilmysliwiec.

In the link that you passed me appears as a range of values 1-12, and I'm reporting that, that the library uses 0 to 11.

image

from schedule.

jkrajinovic avatar jkrajinovic commented on April 26, 2024

@kb05 You are right but I guess its not going to change since schedule depends on cron library which has
wrong range for month.

time js

This should be written in the doc.

@kamilmysliwiec the URL you have sent is wrong.

from schedule.

micalevisk avatar micalevisk commented on April 26, 2024

has wrong range for month.

isn't wrong, it's just how the month part of Date is encoded (0-based)

image

from schedule.

micalevisk avatar micalevisk commented on April 26, 2024

I suggest reporting this to node-cron side instead. I can't tell if they're translating those 1-12 to 0-11 or not.

On NestJS docs there is a mention tp that package, so I guess there's nothing to do on our side.

from schedule.

jkrajinovic avatar jkrajinovic commented on April 26, 2024

Thanks @micalevisk

Sure, are we talking about same cron lib since:
@kamilmysliwiec sent

https://github.com/node-cron/node-cron

but

@nestjs/schedule has dependency on

from schedule.

micalevisk avatar micalevisk commented on April 26, 2024

oh, then we should update the docs. PRs are more than welcomed

https://github.com/kelektiv/node-cron#cron-ranges

from schedule.

jkrajinovic avatar jkrajinovic commented on April 26, 2024

Sure, what repo?

from schedule.

micalevisk avatar micalevisk commented on April 26, 2024

image

https://docs.nestjs.com/techniques/task-scheduling

Change that node-cron to cron. The hyperlink is correct

from schedule.

jkrajinovic avatar jkrajinovic commented on April 26, 2024

nestjs/docs.nestjs.com#2452

Hope the PR is valid.

from schedule.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.