GithubHelp home page GithubHelp logo

Comments (4)

kwin avatar kwin commented on August 18, 2024

The question is how to reliably detect if the last execution of the ACTool was based on a different Cloud Manager build or the same. Potential candidates are:

  1. An Environment variable (not documented by Adobe, therefore may change in the future)
  2. A check over all bundles to get the most recent modification date (Unclear if those dates change when a pod is restarted without a build)
  3. The POM version modified by the pipeline build (Unclear how to identify a bundle having that version from the POM)

from accesscontroltool.

kwin avatar kwin commented on August 18, 2024

Probably just checking if the previous log was a triggered via startup_hook_image_build is enough.

from accesscontroltool.

ghenzler avatar ghenzler commented on August 18, 2024

Regarding the reasons to run the tool automatically on mutable content after each deployment:

  1. content has been modified which is being looped over with the YAML configuration or

this can happen, the question is if the deployment event is the best time to react on such changes (conceivable is also to create listeners for children-changes of all content-derived loops and then automatically run the AC tool without deployment). But then again, usually the most straight forward is not to have content-derived loops but rather define the root folders as master in the AC tool with initialContent

  1. ACEs have been manually modified/deleted/created which affect authorizables managed by ACTool
  2. Authorizables have been manually modified/deleted which are managed by ACTool

I would assume that if manual interaction is allowed (it normally should not be allowed), then it's also ok to "reset to AC Tool config" by running the AC Tool manually

Probably just checking if the previous log was a triggered via startup_hook_image_build is enough.

yes that could be an option if we want to change the behaviour - downside is that usually there is no change to be applied if the config files don't change (so the AC tool will run often in vain, especially for established platforms where the yaml files and root folders rarely change)

from accesscontroltool.

kwin avatar kwin commented on August 18, 2024

if the deployment event is the best time to react on such changes

It happens like this with AEM 6.5, therefore I would first like to align both versions before coming up with a more sophisticated option (listeners always mean quite some overhead)

then it's also ok to "reset to AC Tool config" by running the AC Tool manually

It is not so much about the additional manual step but about the principle of least surprise which is IMHO violated here.

from accesscontroltool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.