GithubHelp home page GithubHelp logo

Comments (3)

DanielThomas avatar DanielThomas commented on September 24, 2024

@brharrington I've worked around this for our use case by holding onto the parsed names, but seems like a nice improvement.

from frigga.

brharrington avatar brharrington commented on September 24, 2024

FWIW with the common IPC project we needed to parse ASG names and ended up just using different logic without regex, summary of JMH benchmarks:

https://github.com/Netflix/spectator/blob/master/spectator-ext-ipc/src/jmh/java/com/netflix/spectator/ipc/ServerGroupParsing.java#L26

Alternative parser:

https://github.com/Netflix/spectator/blob/master/spectator-ext-ipc/src/main/java/com/netflix/spectator/ipc/ServerGroup.java

That said if there are some simple improvements to frigga, it seems like that could benefit many teams.

from frigga.

DanielThomas avatar DanielThomas commented on September 24, 2024

Ah, that alternative will work better for us - we're only ever doing this for server groups.

Nope - that doesn't have the push (i.e. v000) and we need that. I'll stick with parsing them once for now.

from frigga.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.