Comments (10)
OK, let me solve this.
from flat.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from flat.
INVITE_BASEURL
=> WEB_DOMAIN
from flat.
Not sure we support https://example.com/SUB_DIRECTORY/replay/ROOM_TYPE/ROOM_UUID/OWNER_UUID/
kind of link or not.
If we want to support this kind of URL, we should not name it to the domain
. base_url
is better.
BTW, I noticed we already have the constant FLAT_WEB_DOMAIN
in https://github.com/netless-io/flat/blob/main/web/flat-web/src/constants/process.ts.
Use INVITATION_BASE_URL
or INVITATION_ENDPOINT
instead will be better, IMO.
from flat.
In #829, our requirement is to open the replay link, so using INVITATION
/INVITE
is not a good idea in this scenario.
This is because INVITE_BASEURL
and FLAT_WEB_DOMAIN
have a certain overlap.
Their domain names must be the same
see:
Lines 12 to 14 in a19b6be
cc @LitoMore
from flat.
Should we only keep FLAT_WEB_DOMAIN
? Or, keep FLAT_WEB_DOMAIN
and give it a better name, e.g: WEB_DOMAIN
?
from flat.
The link https://{DOMAIN}
with a protocol (https:
) called URL or endpoint.
It's OK to use domain
if it does not have the protocol part.
You could try this in Node.js REPL:
> new URL('https://exmaple.com:8080/test/test/file.ext')
The result will be:
URL {
href: 'https://exmaple.com:8080/test/test/file.ext',
origin: 'https://exmaple.com:8080',
protocol: 'https:',
username: '',
password: '',
host: 'exmaple.com:8080',
hostname: 'exmaple.com',
port: '8080',
pathname: '/test/test/file.ext',
search: '',
searchParams: URLSearchParams {},
hash: ''
}
The domain
and the hostname
are the same thing. Hope this helps you understand the URL.
from flat.
Thanks for the correction, that might be better called FLAT_WEB_ORIGIN
/ FLAT_WEB_URL
/ FLAT_WEB_BASE_URL
?
from flat.
The WEB_URL
sounds like a full URL. Origin
is only used for the HTTP regions, it's not a good choice for URL naming.
FALT_WEB_BASE_URL
looks good.
from flat.
Good. Would anyone like to try and submit a PR for this issue? @netless-io/developers
from flat.
Related Issues (20)
- 执行pnpm start提示您无权限登录
- Can I install this app in HarmonyOS? HOT 2
- 如何自定义主题和UI? HOT 2
- 关于屏幕共享 HOT 2
- 回放页面无法监听到当前播放时间进度 HOT 4
- Ipad不支持屏幕共享吗 HOT 7
- 进入房间后开启录制,结束后回放的后半段是白屏。 HOT 6
- Run pnpm i failed. HOT 4
- Flat Desktop Client Now Available in Arch User Repository (AUR) HOT 4
- electron/js2c/renderer_init.js:93 Unable to load preload script: HOT 5
- Camera blank HOT 4
- [BUG](desktop/classroom-cloud): the subfiles and directories path do not match in classroom cloud setting of Desktop APP
- 开发环境一切正常-MAC打包后检测摄像头麦克风空白,权限提示没弹,MAC版本MACOS Monterey 12.6.7
- UPDATE_DOMAIN检查版本更新, 阿里云上怎么存放Windows 与 Mac 安装包格式 HOT 1
- Why phone number required? HOT 2
- 课堂开启录制报错,麻烦看一下 HOT 1
- Both chrome and edge browsers on Android don't work. HOT 5
- Is it possible to make hyperlinks in Word, PDF, PPT and Excel clickable? HOT 2
- Can I use it in the vue system built by npm? HOT 1
- error with Bluetooth HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flat.