GithubHelp home page GithubHelp logo

Comments (16)

Olicek avatar Olicek commented on July 23, 2024 2

It can be handled in custom renderer. In renderLabel and renderControl methods check if $control is instance of Checkbox. If it's, there can be called getLabelPart or getControlPart insted of getControl.

Don't know if it's good enought solution.

But there is problem with radioList. Problem is here. If i would be able to switch those 2 lines, it would be good enought. What about 5. parameter for createInputList method, witch would be bool and swith those lines. This parameter would be settable in RadioList and CheckboxList

from forms.

dg avatar dg commented on July 23, 2024 1
$form->addCheckbox('xxx')
	->renderLabelSeparately();

from forms.

landsman avatar landsman commented on July 23, 2024

Yes!

from forms.

dg avatar dg commented on July 23, 2024

Can you try to figure out any solution?

from forms.

landsman avatar landsman commented on July 23, 2024

I am thinking about this again :(
What something like:

$form->addCheckbox("terms", "consultation.reserve.terms")->setHTML(...);

This is our problem:
https://api.nette.org/2.4.0/source-Forms.Controls.Checkbox.php.html#65

from forms.

enumag avatar enumag commented on July 23, 2024

As you know I don't use nette/forms anymore... Currently I don't have a need nor time to solve this.

from forms.

enumag avatar enumag commented on July 23, 2024

Closed by accident... it should probably be left open in my opinion.

from forms.

enumag avatar enumag commented on July 23, 2024

@Olicek Can you post the code for renderer? I need this on one of my older projects, fortunately only for single checkboxes, no lists. Also your link to the source doesn't work correctly anymore. You should lock it to one commit.

from forms.

Olicek avatar Olicek commented on July 23, 2024

@enumag I fixed my previous link (thanks for alert). My rendere is on gist. Is it enaught for you? Would you like to have something else?

from forms.

enumag avatar enumag commented on July 23, 2024

@Olicek Actually I already solved it myself but thanks anyway. ;-)

from forms.

dakur avatar dakur commented on July 23, 2024

I suggest to:

  • render <input> before <label> by default – basically to swap these two lines
  • to add id and for attributes for explicitly coupling of <input> and <label>

The problem is that now you can't render checkbox list which is compatible with Bootstrap v5 (or v4 custom control) markup as Bootstrap requires that label follows input. But it's not bootstrap-specific problem.

@dg Do you see any problem or BC break in making proposed changes? I can think only of broken styling if it depends on generated selectors and DOM structure:

form label input[type=checkbox] {
    border: 5px solid red;
}

from forms.

dg avatar dg commented on July 23, 2024

When you change the generated HTML, it is of course a BC break.

from forms.

dakur avatar dakur commented on July 23, 2024

Ok, so what do you suggest then? There should be some way how to affect generated code, if we can not afford to change it.

from forms.

dg avatar dg commented on July 23, 2024

Just add a method to toggle generated code, right?

from forms.

dakur avatar dakur commented on July 23, 2024

I don't understand. Generated code is of type string so what method do you think of that will be able to change it?

from forms.

dakur avatar dakur commented on July 23, 2024

Ok, why not, as basic solution that should be enough. 👍

from forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.