GithubHelp home page GithubHelp logo

ids not generated for hidden inputs about forms HOT 7 CLOSED

nette avatar nette commented on June 24, 2024
ids not generated for hidden inputs

from forms.

Comments (7)

dg avatar dg commented on June 24, 2024

To look in history https://github.com/nette/forms/commits/master/src/Forms/Controls/HiddenField.php is probably faster that to create this issue.

It is experimental.

from forms.

vojtech-dobes avatar vojtech-dobes commented on June 24, 2024

Once again it becomes clear that dependency on generated IDs is good candidate for refactoring :).

from forms.

vysinsky avatar vysinsky commented on June 24, 2024

Once again it becomes clear that dependency on generated IDs is good candidate for refactoring :).

👍

from forms.

bazo avatar bazo commented on June 24, 2024

well, tell to that guy who coded that before me :) refactoring is best done one step at a time, not all at once

btw, what's the reason for this change? i don't think it helps anything or that it would be problematic. it's just harmless and i would guess there would more apps out there that depend on it

i'm for keeping it, like it was in 2.2

from forms.

bazo avatar bazo commented on June 24, 2024

btw, $form['items']->getHtmlId() still returns the generated id, shouldn't it return NULL then?

from forms.

mishak87 avatar mishak87 commented on June 24, 2024

@bazo Did that guy also decided to migrate code instead to next stable to @dev again or was that you?

from forms.

bazo avatar bazo commented on June 24, 2024

and how is that relevant? that was an answer to vojtech. i've already fixed that.
but i'm just asking what advantage this change has?

from forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.