Cannot test Fatal errors about tester

[fprochazka]

@assertCode doesn't work? https://github.com/nette/nette/blob/master/tests/Nette/Diagnostics/Debugger.E_ERROR.production.phpt#L8

[milo]

Oh, I forgot to run it by php-cgi. Thank you, I get it.
EDIT: Deleted unnecessary part in issue message.

[dg]

Good point. In fact, the problem is bigger, because we have no assurance that Debugger::$onFatalError was called. We have, die(0);

[dg]

Ok, I have removed exit() from this 4ebc7a0#L0R42 and added @ExitCode 75a2fe8

[milo]

@dg 👍 But error message from Helpers::setup() still polute the stdoout. What about this solution? milo@c9168c6

[milo]

The idea is: shutdown function from Helpers::setup() is the first one. On fatal error, is called as first and appends next shutdown function on the queue end.

[dg]

This will work only if no other shutdown function will call die(). And Debugger calls die() https://github.com/nette/nette/blob/master/Nette/Diagnostics/Debugger.php#L470.

[milo]

Debugger expects fatal error and test generates one for this purpose. Exit code is fine. I was thinking, that Helpers::setup()'s handler should catch and inform about unexpected fatal error.

[dg]

Yes, I agree. Merged 5d77edc

[dg]

Fuck… https://bugs.php.net/bug.php?id=65275

[milo]

Heh, that is what I commented out in this issue topic message. I was thinking that it is some kind of CLI speciality.

And really nice bug numbers 😄

[milo]

It looks like as some kind of "protection". Only zero code (program success) can be overwritten, any other is kept, so shutdown function cannot chage it to zero.