Backward compatibility for Chef 11 about chef-netuitive

[majormoses]

@emilhdiaz first off thank you for looking into the issue and coming back with useful information about how to solve the problem. While I was hoping to target only chef 12.x when I wrote this I see that there are Netuitive users still using chef 11. This is creating a higher barrier of entry than I had hoped so I am willing to have some chef 11 backwards compatibility. That being said Chef 12.x will be officially supported and Chef 11.x will be best effort.

This particular issue seems like a very simple fix. If you could throw together a patch based off this commit: johnbellone/chef-vault-cookbook@d1d4930 I would be more than happy to review and merge it.

[majormoses]

@emilhdiaz if you are ready could please include a test suite in your .kitchen.yml so I can start testing?

[majormoses]

@emilhdiaz I was taking a look at the way the .kitchen.yml and the tests are set up here is what I am thinking how we should structure it:
I would mv test/integration/default/serverspec test/integration/helpers/serverspec/shared_spec.rb

In test/integration/chef12/serverspec have a simple include on the shared spec and do the same for chef11.

we then rename the default suite in .kitchen.yml to be something like chef12 and set require_chef_omnibus for each version we want to test.

Does this make sense? I am open to other options.

[majormoses]

Just to make sure this is captured here: I have a branch with chef 11 compatibility: https://github.com/Netuitive/chef-netuitive/tree/feature/chef-11-compatibility

This issue is to allow chef 12 and 11 code to coexist peacefully...

[majormoses]

@createor @shawnbutts I dont have access to make the chef 11 branch a protected branch, could you please do so to prevent accidental deletion?

[majormoses]

@emilhdiaz as per: https://discourse.chef.io/t/chef-owned-community-cookbooks-now-require-chef-12-1-or-later/9435 I think that it would not make sense to put forth any further effort on chef 11. I would strongly encourage you to upgrade to a newer version of opsworks as they do support chef 12.