Comments (2)
Thanks for raising the issue.
I think the simple fix is to have it fall back on
json-schema-validator/src/main/java/com/networknt/schema/OneOfValidator.java
Lines 141 to 149 in eea61d6
I don't really have an objection to a specific error message for the missing property, since the spec states If the discriminator value does not match an implicit or explicit mapping, no schema can be determined and validation SHOULD fail.
But if you want to do so then ideally the PR should have a proper fix, meaning that
- Ensure that the missing property message raised is consistent for all the discriminator usages eg.
allOf
,anyOf
,oneOf
- The messages should all be localized (Currently even the current message isn't properly localized and would tack on an english message)
from json-schema-validator.
After looking at this closer it looks like due to the following
To make the behavior consistent with the rest of the usages the logic needs to treat the discriminator as matching if the property is not present in the data and rely on the required
validator to catch the missing discriminator.
I shall probably create the PR to resolve this.
from json-schema-validator.
Related Issues (20)
- Custom Formats are not allowed for types other than Strings HOT 2
- FailFast Property Does Not Throw JsonSchemaException for Validation Errors in v1.3.1 HOT 3
- Too many errors reported when the "unevaluatedProperties" property is used
- Updating the version for com.networknt json-schema-validator from 1.0.74 to 1.3.2 runs into error for : Reference /definitions/testDocument cannot be resolved HOT 5
- Required validation does not seem to be getting triggered HOT 3
- Unevaluated properties and subschemas HOT 1
- Custom Validator for absent values HOT 4
- ethlo as an optional dependency?
- Handle Jackson Databind's 'MissingNode' null object better HOT 2
- Are there plans to support custom vocabularies? HOT 2
- Schema Validation for property from other schmea HOT 3
- date and date-time HOT 5
- format uri does not validate correctly
- How to set the language type of networknt exception information HOT 2
- How to obtain the specific value of an element in the path of abnormal information HOT 3
- JsonNode.canConvertToExactIntegral NoSuchMethodError with current jackson-databind 2.16.2 HOT 2
- Walk in ItemsValidator202012 uses different path than ItemValidator HOT 4
- late Schema mapping not possible in 1.3.x ? HOT 1
- Validate json schema against draft-2020-12 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-schema-validator.