Tests create rubbish files in the project root directory about ephypype

[jasmainak]

okay I see, sure. Either solution works then :)

[dmalt]

@annapasca After running pytest I get a bunch of leftover files inside the ephypype dir

Also if I run pytest twice one of the tests fails to overwrite these files

[jasmainak]

Yikes! This should be fixed indeed

On Wed 3 Oct 2018 at 11:19, dmalt ***@***.***> wrote: @annapasca <https://github.com/annapasca> After running pytest I get a bunch of leftover files inside the ephypype dir [image: image] <https://user-images.githubusercontent.com/8067672/46420446-c3b03080-c738-11e8-92ba-aee6c14ed74a.png> Also if I run pytest twice one of the tests fails to overwrite these files — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APHiohC9NeFO2aoNB2X5uqFe_zpQTvN_ks5uhNWZgaJpZM4XGP0V> .

-- Sent from my iPhone

[dmalt]

For test_cli.py I've been using a tool from click which is called 'isolated filesystem'. It creates a folder with random name in /tmp each time it runs.

[annapasca]

Hi @dmalt thks to highlight this issue.

I have to add also in test_power and test_preproc the tmp dir as in test_fif2ts

I'l wait for the merge of #49 and fix it. Thks!

[jasmainak]

You could also use _Tempdir from mne ...

[annapasca]

You could also use _Tempdir from mne ...

I see...it's a class that also uses tempfile
Do u think it's better to use the _Tempdir class of mne?

[jasmainak]

The "isolated filesystem" seems to change the current directory. Not sure if that fixes your problem. Neuropycon should really not write to the working directory. It should write to a path that is specified by the user ...

[dmalt]

What's the problem with changing CWD to a folder in tmp? You can write there and then it will automatically change back after you're out of the with statement. Explicit path for writing is at hand with os.getcwd(). It's actually quite convenient since it also does the cleaning for you.

[jasmainak]

I'm just a worried that by default neuropycon writes to the current directory. This is a problem not just for tests but for users, no? Using the "isolated filesystem" will hide the issue then.

[dmalt]

Are you talking about the command line utility neuropycon or the whole thing?

[jasmainak]

I mean the whole thing, not just the command line utility ...

[dmalt]

I don't think the whole thing is really related to the unit tests case because if you're a user you specify where to save the results when you create the workflow. At this stage the workflow root is created. Then each node creates its own folder inside root and every function is working inside its separate dir inside this root/node, so it's supposed to save to cwd I think.

[jasmainak]

closed by #55