GithubHelp home page GithubHelp logo

Comments (4)

jdpigeon avatar jdpigeon commented on July 21, 2024

Most of the routing is handled in index.android.js, so most changes should take place there.

We've also put our navigation into Redux in reducer.js

from eeg-101.

jdpigeon avatar jdpigeon commented on July 21, 2024

Made new branch with React-Router work: https://github.com/NeuroTechX/eeg-101/tree/react-router

Seem to save about 20-50 mb at end of app with react-router. Transitions are unanimated but happen more quickly.

from eeg-101.

jdpigeon avatar jdpigeon commented on July 21, 2024

Currently encountering some issues with the new react-router navigation: museDataListeners keep running after component is unmounted.

Will have to look and see whether this is a React or Java issue, or whether this is due to changes in the start/stop thread handling (which was happening before based on redux state keeping track of react-native-router-flux scene keys)

from eeg-101.

jdpigeon avatar jdpigeon commented on July 21, 2024

Completed switch with commit 100! 6def8e4

Looks and feels better now, plus there's a little bit less memory used.

We lost the swipe animations and navbar. However, I'm not missing them.

from eeg-101.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.