GithubHelp home page GithubHelp logo

Comments (3)

hyeshik avatar hyeshik commented on August 16, 2024

The problem is due to xrdp's inverse endianness for virtual channel flags to Microsoft's specification. The following patch fixes the issue.

diff --git a/libxrdp/xrdp_sec.c b/libxrdp/xrdp_sec.c
index 983be09..952ff12 100644
--- a/libxrdp/xrdp_sec.c
+++ b/libxrdp/xrdp_sec.c
@@ -730,7 +730,7 @@ xrdp_sec_process_mcs_data_channels(struct xrdp_sec* self, struct
     channel_item = (struct mcs_channel_item*)
              g_malloc(sizeof(struct mcs_channel_item), 1);
     in_uint8a(s, channel_item->name, 8);
-    in_uint32_be(s, channel_item->flags);
+    in_uint32_le(s, channel_item->flags);
     channel_item->chanid = MCS_GLOBAL_CHANNEL + (index + 1);
     list_add_item(self->mcs_layer->channel_list, (long)channel_item);
     DEBUG(("got channel flags %8.8x name %s", channel_item->flags,

from xrdp.

cuzz avatar cuzz commented on August 16, 2024

It doesn't work yet. I can't use clipboard sharing(clipboard redirection) after modify and recompile the code.
But, what's worse, rdesktop on Linux which is normal to use clipboard redirection before ,now , clipboard redirection can not be used.

      rdp client (mstsc, rdesktop) --->  xrdp -->  rdp server (windows 2003 terminal server)

Test on:
xrdp: CentOS 5.8 Linux x86_64, FreeRDP-FreeRDP-ac5c7cd, FreeRDP-xrdp-c935eb1 (2012-5-10)
rdp-server: windows 2003, Simplified Chinese.

BEFORE applying hyeshik's patch code
(1) rdp-client: Windows 7 x64, Simplified Chinese. mstsc. FAILED.
(2) rdp-client: rdesktop on CentOS 5.8 Linux x86_64 OK.

AFTER that:
(1) rdp-client: Windows 7 x64, Simplified Chinese. mstsc. FAILED.
(2) rdp-client: rdesktop on CentOS 5.8 Linux x86_64 FAILED.

from xrdp.

metalefty avatar metalefty commented on August 16, 2024

Reopen if this issue is not fixed in the latest release (v0.9.1).

from xrdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.