GithubHelp home page GithubHelp logo

Comments (3)

davidbonnet avatar davidbonnet commented on June 16, 2024

Great suggestion!

Indeed, we need an adapter that includes the name as second argument, akin fromEvent:
https://github.com/davidbonnet/realue/blob/e2cd5401266c1daff820fa0ca593238c3da1afa9/src/dom.js#L24-L33)

Could be called fromValue:

export const fromValue = memoize(path => {
  return branch(
    hasProp('onChange'),
    withHandlers({
      onChange: ({ onChange, name }) => value =>
        onChange(path == null ? value : get(value, path), name),
    }),
  )
})

from realue.

gtnx avatar gtnx commented on June 16, 2024

Sure we can do that but I still don't understand why the name is required in the onChange prop provided by object hoc.

In other words, what would be the cost of turning this code:

https://github.com/davidbonnet/realue/blob/e49585c8e50d3bf7f0e914cc7de5333112afdec6/src/objects.js#L28-L38

into

  withHandlers({
    property: ({ value, onChangeProperty }) => (
      name,
      key = name,
    ) => ({
      value: value[name],
      key,
      name,
      onChange: (value, payload) => onChangeProperty(value, name, payload),
    }),
  }),

from realue.

davidbonnet avatar davidbonnet commented on June 16, 2024

@gtnx: The cost is similar to assigning a function expression to a prop: it updates at each render.

from realue.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.