Comments (3)
Great suggestion!
Indeed, we need an adapter that includes the name
as second argument, akin fromEvent
:
https://github.com/davidbonnet/realue/blob/e2cd5401266c1daff820fa0ca593238c3da1afa9/src/dom.js#L24-L33)
Could be called fromValue
:
export const fromValue = memoize(path => {
return branch(
hasProp('onChange'),
withHandlers({
onChange: ({ onChange, name }) => value =>
onChange(path == null ? value : get(value, path), name),
}),
)
})
from realue.
Sure we can do that but I still don't understand why the name
is required in the onChange
prop provided by object
hoc.
In other words, what would be the cost of turning this code:
into
withHandlers({
property: ({ value, onChangeProperty }) => (
name,
key = name,
) => ({
value: value[name],
key,
name,
onChange: (value, payload) => onChangeProperty(value, name, payload),
}),
}),
from realue.
@gtnx: The cost is similar to assigning a function expression to a prop: it updates at each render.
from realue.
Related Issues (16)
- Version 10 of node.js has been released
- An in-range update of @std/esm is breaking the build 🚨 HOT 5
- An in-range update of prettier is breaking the build 🚨 HOT 6
- Add boolean decorator which defaults to true HOT 1
- An in-range update of parcel-bundler is breaking the build 🚨 HOT 3
- An in-range update of react is breaking the build 🚨 HOT 5
- Explain conventions
- Add examples
- Roadmap
- An in-range update of react is breaking the build 🚨 HOT 13
- An in-range update of eslint is breaking the build 🚨 HOT 1
- Version 4
- An in-range update of prettier is breaking the build 🚨 HOT 2
- withBounds debounces very slowly if we are making the window smaller, it works fine if we make the window bigger HOT 1
- withChildren childProps supposed to be optional HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from realue.