GithubHelp home page GithubHelp logo

Comments (6)

Fevix avatar Fevix commented on July 26, 2024

My bad. ColtCelestia here, I didn't realize there was a github.

More information about the failure, at least the version I'm getting:
Nothing crashes, as far as I can tell, but the browser does appear to be downloading information (As evidenced by the favicon part of the tab turning into the blue (Chrome) or green (Firefox) animated circle), but after a while it stops that, Chrome opting to display a 'webpage unavailable' page

Edit: It seems that the behavior has changed, now I'm being redirected to the blog's main Ask page (Rather than getting the in-dashboard popup box as per my settings)

from xkit.

bvtsang avatar bvtsang commented on July 26, 2024

I'm having trouble reproducing this with the following steps, which assumes you have control over accounts A and B:

  1. On Account A, make sure User Menus+ is enabled
  2. Visit your dashboard
  3. Hover your mouse over Account B's avatar
  4. In the popup, click on the User Menu and click Ask a Question
  5. Anonymously or not, type a message and click Ask
  6. On Account B, expect to receive the ask

This currently works for me.

from xkit.

Wolvan avatar Wolvan commented on July 26, 2024

I get redirected to the blog B's ask page instead of having a popup ask box open. I'll see if I can do something about that tomorrow

from xkit.

bvtsang avatar bvtsang commented on July 26, 2024

If I turn enable XKit's Classic User Menu, then at step 4 I get redirected to the user's ask page. I guess I need to test more thoroughly.

Updated steps to reproduce:

  1. Make sure User Menus+ is enabled
  2. Enable XKit's Classic User Menu
  3. Visit your dashboard
  4. Hover your mouse over any avatar whose account has asks enabled
  5. Expect to see a popup with a form where the user can enter in their ask
  6. Observe that the user is redirected to the blog's main ask page instead

Thanks for looking at it, Wolvan!

from xkit.

WyohKnott avatar WyohKnott commented on July 26, 2024

Because the normal menu popup is handle by a Tumblr event.
Maybe we should trigger it ourselves:

 Tumblr.Events.trigger('indashblog:tumblelog:ask', {
    recipient: this.model.get('name'),
    anonymous_asks: this.model.get('anonymous_asks')
  });

But I don't like that we rely on inject script so much.

from xkit.

bvtsang avatar bvtsang commented on July 26, 2024

@WyohKnott I took your advice and tried https://gist.github.com/bvtsang/b879bee8a960566c0c68, but nothing happens. I guess I'll keep investigating this in the meantime.

Edit: I found a hint in Tumblr.DashboardAsk.open_ask. Currently researching this. I DID IT pull request incoming shortly

from xkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.