K stops working after a new dash page loads about xkit

[blindcat97]

I also have this issue, though it's a little different. On mine, K doesn't stop working completely, but only scrolls up a few lines instead of the whole post. Very annoying for trying to jump back over long posts. I'm using Chrome 44 (newest available version) and am on Windows 8.1.

[eggkin]

I have this problem too, though I haven't been able to figure out why. It didn't start until I got the new xkit yesterday though

[meiloslyther]

Same as blindcat97, but it comes and goes, though it usually doesn't work. Disabling xkit doesn't help, so not sure if it's that or not. Windows 7, Chrome.

[nightpool]

I seem to be missing some context here—what is k?

[blindcat97]

The K key on the keyboard.

[gloomykid]

i have the same issue on chrome, win7.

[WyohKnott]

IIRC, we intercept Tumblr's shortcuts in one_click_postage in order to add our own shortcuts. For this, we inject a script in the page to access Tumblr.KeyCommands.suspend(), which disables K/J etc…

Theorically once the key is processed, we call Tumblr.KeyCommands.resume() but I remember searching for a race condition in the code a few months ago. That might explain this, but wouldn't explain why it happens on a new page.

[inklesspen]

@blindcat97 I think I stopped experiencing the "jump up only a few pixels" problem when I turned on the option to jump over a whole post even if it was too big for the screen.

[blindcat97]

@inklesspen Where is this option? I can't find it in the one-click postage or tweaks menus (assuming my extensions are all updated, which they seem to be).

[inklesspen]

In the J/K Across Pages extension

[blindcat97]

I installed the extension and checked this option, but it still does not work. I'd like to mention that I have also discovered that it works as a toggle; after passing the first page, this strange behaviour begins, and it continues even when I return to the first page, even though it wasn't acting up when I originally loaded the page.

[meiloslyther]

I don't know if anyone's clarified this, but I use endless scrolling on my dash. I tested turning it off (albeit only once) and K seems to start working again. Maybe it's just being temperamental though.

I also never installed the J/K Across Pages extension because endless scrolling.

[gloomykid]

the k button only doesnt work from page 6/7+ and further. if youre using infinite scrolling and reach page 2 or more, it wont work anymore. so i guess i have to turn off infinite scroll until it is fixed, even if its really pesky, but id recommend that to anyone who uses the k button instead of mouse scrolling.

[inklesspen]

Correction to my earlier comment: enabling the "jump over entire post" option has not fixed this issue.

[gloomykid]

ive tested running tumblr with xkit and without any other add-on, and the j/k button issue is still a thing if using infinite scroll instead of pages.

as soon as you hit the 2nd page, it wont work. that is the issue ive collected so far.

the question is if you want me to test if its an extention from xkit that collides with j/k?

[gloomykid]

Guys, I've found the causing problem for the issue to get to the previous post with K.
It's "Reblog as Text". If I disable said extention, my K button still works just fine.

Honestly, I don't even know if this is necessary to use, because of the whole interface change, I don't know if long text posts will still be converted into links. But if they still turn into links instead of long text posts, I'd suggest some fix for that.
Otherwise, we are good to just forget about this extention.
Anyone an idea if it's still needed?

[bvtsang]

I'm interpreting "K not working" in two ways:

1. Pressing K while at the top of the screen doesn't navigate to the previous page
2. Pressing K doesn't skip over an entire post, but scrolls up a tiny bit instead

In my testing, I've never encountered the first case. But I've encountered the second case even with J/K disabled, which leads me to believe that this is an issue with Tumblr's J/K functionality related to the race condition noted by WyohNott.

[meiloslyther]

While I don't think that Reblog As Text is necessary anymore (it appears that you can't change post types anyway), after some testing, disabling it does not help the situation completely. If I hit the "End" button while Tumblr is still loading, the K button will still act like the up arrow. Although, waiting for Tumblr to fully load first is what I've been doing to prevent this from happening about 75% of the time anyway.

And yes, bvtsang, 2 is the problem I was having at least (1 isn't even applicable to me).

[inklesspen]

I have experienced both problems 1 and 2. I have disabled, but not removed, Reblog as Text, and I am still experiencing problem 2.

[gloomykid]

I only have problem number 2, which I described in my previous comments. And that number 2 issue with the K button is what I meant with the Reblog as Text.
I might be wrong but it works for me until now, I might still encounter a bug with the K button but I hope I fixed it.

EDIT:
Okay, Reblog as Text is not fixing it. I'm clueless. I don't know if the "K to next post"-bug is a tumblr interface bug or if it's XKit.

[coderpatsy]

I've always assumed the bug was due to Tumblr Savior and hadn't bothered to test.

[dlmarquis]

Has anyone (@bvtsang? @hobinjk?) tried looking at the K buffer to see if it breaks on loading a new infiniscroll page? I'll make an attempt but I dunno how well it will work from mobile.

[invalidCards]

@dlmarquis #645 has been confirmed to be a bug - is this issue exactly the same or is it unrelated? If it is, does this still happen?

[dlmarquis]

@ThePsionic these are separate. I experience this bug without Blacklist installed.

[invalidCards]

@dlmarquis Hm, I can't reproduce with a fresh install on Firefox. Any more details to this?

[gloomykid]

I only experience it on Chrome... did you reproduce it earlier on Firefox as well, @ThePsionic ? I have no other clue to it anymore, and it must be an XKit extension because I've disabled everything else. How about those who said it wouldn't occur if the dashboard isn't on infinite scroll? I can only say that it won't happen on the dasboard, if I have XKit disabled...

[invalidCards]

@gloomykid Just tested it on Chrome as well with Blacklist disabled (because of #645), and I can J/K just fine. Extension dump if you need it.