GithubHelp home page GithubHelp logo

Comments (9)

nightpool avatar nightpool commented on July 26, 2024

I had a similar experience testing the new extension on chrome.

from xkit.

nightpool avatar nightpool commented on July 26, 2024

the offending line seems to be xkit.js:758

    if ($("#dashboard_controls_open_blog").length === 0)

which was from the old blog stats bar. Not sure which plugin hides these, but we add them back in. Maybe do the opposite and a check for > 0 would be useful?

from xkit.

nightpool avatar nightpool commented on July 26, 2024

also this line is also true:

$(".likes").length === 0 || $(".following").length === 0 || $(".spotlight").length === 0

in fact, none of these classes are present at this time

from xkit.

dlmarquis avatar dlmarquis commented on July 26, 2024

@nightpool Tumblr removed that entire div, so that bit of code should be removed. I'll deal with it, but I'm on a roadtrip right now and my internet could cut out at any time, so it might be a couple hours before you see the changes.

from xkit.

dlmarquis avatar dlmarquis commented on July 26, 2024

Just submitted the changes. They'll be incorporated into the next release of XKit.

from xkit.

nightpool avatar nightpool commented on July 26, 2024

@dlmarquis I can deal with it, I'm just wondering if there's anything we should put in its place. (we should probably try to detect for old-xkit, for example)

do we have any known conflicts with other tumblr plugins?

from xkit.

dlmarquis avatar dlmarquis commented on July 26, 2024

@nightpool It should be detecting old versions of Xkit already, but that appears to be broken at the moment. It's probably just a matter of bumping the version number.

We know there's a conflict with Stylish that makes XKit unusable, but we don't know why, since Stylish plays nice with the old version. That probably deserves its own issue.

from xkit.

nightpool avatar nightpool commented on July 26, 2024

@dlmarquis sounds good.

from xkit.

nightpool avatar nightpool commented on July 26, 2024

fixed by #95

from xkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.