Errors are reported despite that Error Collector is disabled about go-agent

[willnewrelic]

Hi VadimBelov

If ErrorCollector.Enabled is set to false, errors and error events should not be captured due to the following conditional:
https://github.com/newrelic/go-agent/blob/master/internal_txn.go#L284

I don't see any code issues and everything works as expected in my tests. Could you please try testing this again?

[VadimBelov]

Hi willnewrelic,
The errors that I see reported in New Relic APM page ("Error Analytics" and "Errors" views under EVENTS section) are panic events that occur in the middle of a transaction.
Considering this we assume that nor "analytics events" neither "traced errors" (the views described above) should show events if Error Collector is disabled.

[willnewrelic]

Hi VadimBelov

I think I understand the issue now:

When ErrorCollector.Enabled is set to false, the go-agent still creates error metrics. This shows that errors are happening on the "Errors" and "Error Analytics" pages, even though examples of these errors are not being captured.

Though this is intended behavior, I see how it could be surprising and confusing. I will research this issue, and we will either change the behavior or improve the documentation.

Expect an update next week.

[willnewrelic]

Hi VadimBelov

Just released version 1.2. This version has a fix: Error metrics are no longer created when ErrorCollector.Enabled is set to false. I am hopeful that this solves your issue!

Closing this issue: Please reopen it if problems persist.