Comments (8)
Hi Dan
I presume you are using WrapHandle
and/or WrapHandleFunc
and would like to notice an error in one of your handlers? Use type assertion on the http.ResponseWriter
:
func noticeError(w http.ResponseWriter, r *http.Request) {
if txn, ok := w.(newrelic.Transaction); ok {
txn.NoticeError(errors.New("my error message"))
}
}
from go-agent.
So when I do that, I end up with 2 errors in new relic, not 1.
from go-agent.
Disabling the normal http response code error instrumentation (and using NoticeError
) will be easier than modifying the agent. I recommend adding the following configuration:
cfg.ErrorCollector.IgnoreStatusCodes = []int{500, 501} // and any other codes
I understand the friction here: It would be nice to easily add some "why" context to the automatically captured response code errors. We will contemplate this.
from go-agent.
Excellent, that was what I was trying to get at. I was about to ask if there was a way to disable the default status code error. Thanks, I'll try that now!
from go-agent.
@willnewrelic Hmm, on second thought, this sucks. If I want to never have those errors fire, I need to list all 400 and 500 status codes?
Alternatively, I can add my error to the current transaction via AddAttribute, and in the new Error Analytics view, I can click on that custom attribute to get a listing by count of each error string. That seems like the best solution so far.
from go-agent.
Understood. A setting to disable status code errors entirely would be great here. We will discuss this.
Happy to hear the attribute/error-analytics approach is working!
from go-agent.
Are you suggesting a way to disable the status code errors per-transaction or globally?
from go-agent.
@lpetre Considering anything and everything! A transaction method for per-transaction disabling would be more powerful, but a global config setting in the Config would be simpler for customers that want to always have it disabled.
from go-agent.
Related Issues (20)
- Consumes a lot of memory during large body size requests HOT 2
- External Services(AWS sdk go v2 ) api calls are not logged / visible when using github.com/newrelic/go-agent/v3/integrations/nrawssdk-v HOT 3
- Remove fasthttp dependency from main module HOT 2
- Update google.golang.org/grpc from 1.54.0 to 1.56.3 HOT 2
- transaction.go reqBody(req *http.Request) turn nil body into non Nil body for request.Body == http.NoBody HOT 1
- Add support to CopyFrom method in pgx integration HOT 1
- fmt.Stringer support for user attributes (especially for SQL query parameters)
- UNKNOWN log levels when using the native log package HOT 2
- `.Ignore()` not ignoring transaction (go-agent + nrgin) HOT 6
- Integration for gqlgen HOT 2
- nrpgx5 data-race HOT 5
- Changelog Go agent EOL Policy link is broken HOT 1
- agent with nrzap is not forwarding logs to newrelic HOT 3
- WrapBackgroundCore background logger is not sending logs to new relic but transaction logger is HOT 12
- zap logger.With log message properties are not sent to new relic HOT 4
- Attributes are not forwarded to NewRelic for logs HOT 16
- go agent , but not see span, please help me ,thanks HOT 3
- Specify service version during initial newrelic configuration HOT 6
- Possible memory leak in Go agent HOT 11
- How to use AWS Lambda Web Adapter in golang app
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-agent.