Comments (6)
Aside: Is there any sort of CI system setup to run these tests? Would you consider a test matrix for multiple Go versions using something like TravisCI? Let me know if you would like a PR for that.
from go-agent.
The failure in TestCopyConfigReferenceFieldsPresent
is due to the way numbers are being encoded in Go 1.8.
"Marshal encodes floating-point numbers using the same format as in ES6, preferring decimal (not exponential) notation for a wider range of values. In particular, all floating-point integers up to 264 format the same as the equivalent int64 representation." https://beta.golang.org/doc/go1.8
I don't imagine that related to why we stopped seeing any metrics in New Relic. It's just a change that the string comparison in this test doesn't account for.
from go-agent.
Hi @nathany
Thanks for the heads up! We will fix this shortly.
We have a CI system internally: We are looking into what system would work for both public and private development.
from go-agent.
Thanks Will.
I think the issue we experienced with losing New Relic data wasn't related to Go 1.8, but instead from switching from golang:1.7.4-alpine
(Docker) to alpine:3.5
. I don't see why New Relic go-agent would require the Go compiler, but perhaps there is something else it needs that exists in the golang image?
As far as this issue, maybe using smaller (single digit?) values would satisfy the tests across both Go 1.7 and Go 1.8, assuming that the tests stick with hard coded JSON output.
from go-agent.
@nathany I don't have any insight into how the Docker change could affect agent behavior. Are you still experiencing this problem? If so, let's address it in a separate issue or support ticket.
Go 1.8 tests fixed as part of the latest 1.6.0 release! Thanks for bringing this to our attention!
from go-agent.
Thanks @willnewrelic.
from go-agent.
Related Issues (20)
- Consumes a lot of memory during large body size requests HOT 2
- External Services(AWS sdk go v2 ) api calls are not logged / visible when using github.com/newrelic/go-agent/v3/integrations/nrawssdk-v HOT 3
- Remove fasthttp dependency from main module HOT 2
- Update google.golang.org/grpc from 1.54.0 to 1.56.3 HOT 2
- transaction.go reqBody(req *http.Request) turn nil body into non Nil body for request.Body == http.NoBody HOT 1
- Add support to CopyFrom method in pgx integration HOT 1
- fmt.Stringer support for user attributes (especially for SQL query parameters)
- UNKNOWN log levels when using the native log package HOT 2
- `.Ignore()` not ignoring transaction (go-agent + nrgin) HOT 6
- Integration for gqlgen HOT 2
- nrpgx5 data-race HOT 5
- Changelog Go agent EOL Policy link is broken HOT 1
- agent with nrzap is not forwarding logs to newrelic HOT 3
- WrapBackgroundCore background logger is not sending logs to new relic but transaction logger is HOT 12
- zap logger.With log message properties are not sent to new relic HOT 4
- Attributes are not forwarded to NewRelic for logs HOT 16
- go agent , but not see span, please help me ,thanks HOT 3
- Specify service version during initial newrelic configuration HOT 6
- Possible memory leak in Go agent HOT 11
- How to use AWS Lambda Web Adapter in golang app
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-agent.