GithubHelp home page GithubHelp logo

concurrency and transactions about go-agent HOT 4 CLOSED

newrelic avatar newrelic commented on July 19, 2024 1
concurrency and transactions

from go-agent.

Comments (4)

bhcleek avatar bhcleek commented on July 19, 2024

I should clarify that the lifetime of the goroutines that make the subrequests is always within the lifetime of the goroutine that starts them.

from go-agent.

cmiller01 avatar cmiller01 commented on July 19, 2024

This use case would be very helpful for us as well. @bhcleek in our initial testing of the tracing we were passing around the same Transaction within new goroutines, and as the docs point out this didn't really work. It appeared that data was being intermittently dropped.

from go-agent.

peterhellberg avatar peterhellberg commented on July 19, 2024

I would also be interested in knowing more about how to deal with this use-case (multiple goroutines, all with a shorter lifetime than the original goroutine)

If this isn't possible, how about supporting sub-transactions?

from go-agent.

astormnewrelic avatar astormnewrelic commented on July 19, 2024

@bhcleek Good eye! Unfortunately, those comments (while a little unclear) are accurate. Without getting too deeply into it, both NewRoundTripper and Transaction weren't explicitly designed with concurrency in mind, and spawning off go routines that access/manipulate the same Transaction can (sometimes) introduce subtle timing/accuracy issues with segments (and possibly other places? )

That said (to echo @cmiller01 and @peterhellberg, thanks both!) better concurrency support would be a pretty sweet feature to have. We're logging/tracking it internally and while we can't promise a delivery date it is on our radar.

We're closing this issue out, but if you still have questions don't hesitate to chime in below or via another one of our support channels.

from go-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.