Comments (4)
I should clarify that the lifetime of the goroutines that make the subrequests is always within the lifetime of the goroutine that starts them.
from go-agent.
This use case would be very helpful for us as well. @bhcleek in our initial testing of the tracing we were passing around the same Transaction
within new goroutines, and as the docs point out this didn't really work. It appeared that data was being intermittently dropped.
from go-agent.
I would also be interested in knowing more about how to deal with this use-case (multiple goroutines, all with a shorter lifetime than the original goroutine)
If this isn't possible, how about supporting sub-transactions?
from go-agent.
@bhcleek Good eye! Unfortunately, those comments (while a little unclear) are accurate. Without getting too deeply into it, both NewRoundTripper
and Transaction
weren't explicitly designed with concurrency in mind, and spawning off go routines that access/manipulate the same Transaction can (sometimes) introduce subtle timing/accuracy issues with segments (and possibly other places? )
That said (to echo @cmiller01 and @peterhellberg, thanks both!) better concurrency support would be a pretty sweet feature to have. We're logging/tracking it internally and while we can't promise a delivery date it is on our radar.
We're closing this issue out, but if you still have questions don't hesitate to chime in below or via another one of our support channels.
from go-agent.
Related Issues (20)
- Remove fasthttp dependency from main module HOT 2
- Update google.golang.org/grpc from 1.54.0 to 1.56.3 HOT 2
- transaction.go reqBody(req *http.Request) turn nil body into non Nil body for request.Body == http.NoBody HOT 1
- Add support to CopyFrom method in pgx integration HOT 1
- fmt.Stringer support for user attributes (especially for SQL query parameters)
- UNKNOWN log levels when using the native log package HOT 2
- `.Ignore()` not ignoring transaction (go-agent + nrgin) HOT 6
- Integration for gqlgen HOT 2
- nrpgx5 data-race HOT 5
- Changelog Go agent EOL Policy link is broken HOT 1
- agent with nrzap is not forwarding logs to newrelic HOT 3
- WrapBackgroundCore background logger is not sending logs to new relic but transaction logger is HOT 12
- zap logger.With log message properties are not sent to new relic HOT 4
- Attributes are not forwarded to NewRelic for logs HOT 16
- go agent , but not see span, please help me ,thanks HOT 3
- Specify service version during initial newrelic configuration HOT 6
- Possible memory leak in Go agent HOT 11
- How to use AWS Lambda Web Adapter in golang app
- uber/zap WithField(...) not showing up in NR APM logs HOT 2
- potential bug in newAppRun HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-agent.