GithubHelp home page GithubHelp logo

Comments (5)

workato-integration avatar workato-integration commented on June 30, 2024

https://new-relic.atlassian.net/browse/NR-273271

from newrelic-ruby-agent.

tannalynn avatar tannalynn commented on June 30, 2024

Thanks for the feedback on the strip instrumentation! That is a good point for us to look into, I can definitely see how that could lead to a large number of metric names. Currently we use this to create the name

        def metric_name(event)
          "Stripe#{event.path}/#{event.method}"
        end

So we'll need to take a second look here to see the best way to extract some of the more useful information out of the path while not including those ids, since removing event.path completely would leave metric names that simply look like "Stripe/get".

from newrelic-ruby-agent.

jdelStrother avatar jdelStrother commented on June 30, 2024

Yeah, agreed. All the stripe ids I know of are 2-3 letters (eg cus, sub, in), then an underscore, then a bunch of letters/numbers - I wondered if you might be able to do some regex magic to scrub those.
(yes yes, and then you have two problems 😛)

from newrelic-ruby-agent.

kford-newrelic avatar kford-newrelic commented on June 30, 2024

@jdelStrother thank you for giving us this feedback - our engineers agreed with you that our current instrumentation behavior is not desirable - we plan to take this up during the next quarter.

However, it was also agreed that, though not desirable, the current behavior isn't a bug per se, so we'll be treating this as an enhancement (which likely won't matter to you)

from newrelic-ruby-agent.

kford-newrelic avatar kford-newrelic commented on June 30, 2024

Overruled by engineers. Re-classifying as a bug

from newrelic-ruby-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.