Comments (5)
https://new-relic.atlassian.net/browse/NR-273271
from newrelic-ruby-agent.
Thanks for the feedback on the strip instrumentation! That is a good point for us to look into, I can definitely see how that could lead to a large number of metric names. Currently we use this to create the name
def metric_name(event)
"Stripe#{event.path}/#{event.method}"
end
So we'll need to take a second look here to see the best way to extract some of the more useful information out of the path while not including those ids, since removing event.path
completely would leave metric names that simply look like "Stripe/get
".
from newrelic-ruby-agent.
Yeah, agreed. All the stripe ids I know of are 2-3 letters (eg cus
, sub
, in
), then an underscore, then a bunch of letters/numbers - I wondered if you might be able to do some regex magic to scrub those.
(yes yes, and then you have two problems 😛)
from newrelic-ruby-agent.
@jdelStrother thank you for giving us this feedback - our engineers agreed with you that our current instrumentation behavior is not desirable - we plan to take this up during the next quarter.
However, it was also agreed that, though not desirable, the current behavior isn't a bug
per se, so we'll be treating this as an enhancement (which likely won't matter to you)
from newrelic-ruby-agent.
Overruled by engineers. Re-classifying as a bug
from newrelic-ruby-agent.
Related Issues (20)
- Add Rails 7.2-specific test environments HOT 3
- CI: Ruby v3.4.0-preview1 fails to provide SQL explain plan info for Sequel HOT 2
- Newrelic 9.10.0 breaks our CI - caused by a collision with the 'bootstrap' gem HOT 11
- NewRelic 9.10.0 stopped reporting background jobs HOT 6
- SQS end to end testing HOT 1
- Logs full of undefined method `access_key_id' HOT 8
- ActiveSupport notifications improvements HOT 1
- FOSSA Ruby scanning - enhancements for our public repos HOT 2
- Add testing constraints for ffi HOT 1
- Revert `autostart_denylisted_constants` default change and document options HOT 1
- Spike: Investigate `autostart.denylisted_constants` HOT 1
- Investigate rspec-mocks incompatibility with `add_method_tracer` HOT 3
- Add a configuration option to permit custom method tracers to be defined automatically HOT 1
- CI: GHA - DRY up the action version shas HOT 1
- Meet OYC standards for Agent2Query service HOT 2
- Add Errors Inbox metadata configuration content to generated doc HOT 3
- [Spike] k8s & container integration HOT 1
- [Spike] Support FM/SA configuration HOT 1
- API driven noticed errors display as `expected: true`, and observed errors should too HOT 2
- Stripe integration Causes Cardinality Explosion HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newrelic-ruby-agent.