GithubHelp home page GithubHelp logo

Comments (7)

tkrajcar avatar tkrajcar commented on August 17, 2024

None come to mind - I say go for it. Thank you!

from newrelic-ruby-kata.

jasonrclark avatar jasonrclark commented on August 17, 2024

That would be awesome! ✨

I popped Rails 4.x in briefly once, and as I recall why I didn't roll with it was that at least one of the samples actually wasn't slow anymore in the base case. So that'd be my only recommendation about it--will see if I made any notes on what was too fast at the time and get back on this issue with it.

Thanks @vosechu!

from newrelic-ruby-kata.

jasonrclark avatar jasonrclark commented on August 17, 2024

My notes say https://github.com/newrelic/newrelic-ruby-kata/blob/master/app/controllers/big_list_controller.rb no longer exhibited a perf issue once moved to Rails 4.x... Odd to be trying to make slow code, but there you go 😏

from newrelic-ruby-kata.

vosechu avatar vosechu commented on August 17, 2024

Thanks @jasonrclark. I'll take a wing at it shortly. @elauervose is doing some work on this so it's fun to do something along side of her!

from newrelic-ruby-kata.

vosechu avatar vosechu commented on August 17, 2024

@jasonrclark @tkrajcar Let me know what you think about the PR. I was able to finish it last night and I hope that it'll help new people get into it.

The bootstrap changes alone would be a huge hangup for new people. :)

from newrelic-ruby-kata.

jasonrclark avatar jasonrclark commented on August 17, 2024

Changes look good to me on a first reading. I'm going to sit down and actually test through them side-by-side with the old version to make sure everything still behaves. If there's anything small, I'll probably just fix it, and will let you know how it's going. Thanks again for tackling this!

from newrelic-ruby-kata.

vosechu avatar vosechu commented on August 17, 2024

That would be awesome Jason. Let me know if there's big things that need whacking. :)

from newrelic-ruby-kata.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.