GithubHelp home page GithubHelp logo

Comments (4)

ardias avatar ardias commented on June 11, 2024

@Kav91 Can you try again? I was aware and had a fix in a PR. I merged it, should fix the local build

from nri-flex.

Kav91 avatar Kav91 commented on June 11, 2024

@ardias I tried but the behaviour is not the same.
It always puts Unknown-SNAPSHOT as the version when it should be using the git sha and flagging dirty when needed.

from nri-flex.

ardias avatar ardias commented on June 11, 2024

Yes, when using local compilation it does that. When it is released the version is set at the release version.
We prefer that released version are used, but do you have a use-case for setting it as the git sha on a local compiled version?

from nri-flex.

Kav91 avatar Kav91 commented on June 11, 2024

Yes, because when you are creating test releases you can quickly understand and see what version you or a customer is running. It's been extremely useful and critically when debugging.
Without it we can't reliably figure this out and track correctly.

from nri-flex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.