Comments (3)
This is unfortunately how the infrastructure SDK handles Fatal errors by calling Panic ( https://github.com/newrelic/infra-integrations-sdk/blob/master/log/log.go#L107 ) vs Logrus which calls Exit ( https://github.com/sirupsen/logrus/blob/master/logger.go#L182 ) Unsure of their choice, but the integration itself does the right thing (captures the error, reports it, tries to exit)
Might be worth moving away from the SDK logger and to Logrus @Kav91 ? Especially now that there are other endpoints beside OHI.
from nri-flex.
Yep agree, I wanted to use Logrus for this reason and also because I wanted to add discovery for Fargate, and cloudwatch logs are nice when they are received JSON formatted and with timestamps, so prefer the additional control Logrus would give.
from nri-flex.
@AlecIsaacson @jthurman42 infra log package has been removed in 0.6.0 #7 , and logrus is being used now. So this panic no longer occurs π
from nri-flex.
Related Issues (20)
- linux-file-count.yml does not work as-is
- Review/create e2e tests to be able to upgrade go version HOT 1
- Upgrade Go version to > 1.15
- Flex IP Discovery on Kubernetes HOT 3
- Flex not working though API call works with Curl -k HOT 1
- Impossible to use the '%' character in a db query (MySQL)
- Running Flex Serverless - Azure Function App?
- Getting Parse errors in case if docker discovery doesn't finds any suitable containers
- Add support for Oracle DB HOT 1
- null value being converted to unicode HOT 8
- [Repolinter] Open Source Policy Issues HOT 1
- Extra middle whitespace in `name: nri-flex` throws an error HOT 3
- "lookups" function fails when looking up more than one value in same command HOT 1
- [Repolinter] Open Source Policy Issues HOT 1
- Sampling rate to New Relic does not go below 15s HOT 2
- [Repolinter] Open Source Policy Issues HOT 1
- Not possible to add user/pass as global to invoke PowerShell script with specific credentials HOT 3
- Swedish characters like Γ₯Àâ is not working in Flex via PowerShell HOT 3
- Recursively get data by using the 'nextCursor' attribute in Nerdgraph API HOT 2
- Dependency Dashboard HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nri-flex.