GithubHelp home page GithubHelp logo

Comments (3)

jthurman42 avatar jthurman42 commented on June 11, 2024 1

This is unfortunately how the infrastructure SDK handles Fatal errors by calling Panic ( https://github.com/newrelic/infra-integrations-sdk/blob/master/log/log.go#L107 ) vs Logrus which calls Exit ( https://github.com/sirupsen/logrus/blob/master/logger.go#L182 ) Unsure of their choice, but the integration itself does the right thing (captures the error, reports it, tries to exit)

Might be worth moving away from the SDK logger and to Logrus @Kav91 ? Especially now that there are other endpoints beside OHI.

from nri-flex.

Kav91 avatar Kav91 commented on June 11, 2024

Yep agree, I wanted to use Logrus for this reason and also because I wanted to add discovery for Fargate, and cloudwatch logs are nice when they are received JSON formatted and with timestamps, so prefer the additional control Logrus would give.

from nri-flex.

Kav91 avatar Kav91 commented on June 11, 2024

@AlecIsaacson @jthurman42 infra log package has been removed in 0.6.0 #7 , and logrus is being used now. So this panic no longer occurs πŸ˜„

from nri-flex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.