GithubHelp home page GithubHelp logo

Comments (8)

tobiasKaminsky avatar tobiasKaminsky commented on July 22, 2024

For android we need to change the useragent: nextcloud/android#1852
But then we could block all ownCloud clients and all Nexcloud <2.1 for E2E.

from end_to_end_encryption.

rullzer avatar rullzer commented on July 22, 2024

I'm not sure we have to infrastructure around to fix this. But I do agree. However I would just block them in general if E2E is enabled.

from end_to_end_encryption.

tobiasKaminsky avatar tobiasKaminsky commented on July 22, 2024

Currently we use the same useragent "Mozilla/5.0 (Android) ownCloud-android/$versionNumber".
As ownCloud is on version 2.5 and we will release 2.1 we cannot block them that easily depending only on the versionNumber. So we need to change the user agent...

from end_to_end_encryption.

tobiasKaminsky avatar tobiasKaminsky commented on July 22, 2024

@rullzer what is missing on server side to do this?

from end_to_end_encryption.

marinofaggiana avatar marinofaggiana commented on July 22, 2024

I use : Mozilla/5.0 (iOS) Nextcloud-iOS/2.19.0

check E2E < 2.19.0

from end_to_end_encryption.

georgehrke avatar georgehrke commented on July 22, 2024

@camilasan @misch7 What version of the desktop client should we block?

from end_to_end_encryption.

georgehrke avatar georgehrke commented on July 22, 2024

@rullzer what is missing on server side to do this?

Not much, we can just listen on Sabre/DAV requests in check the user agent, no big deal.
Would should the error message be like?

from end_to_end_encryption.

georgehrke avatar georgehrke commented on July 22, 2024

it seems this was already worked on: https://github.com/nextcloud/end_to_end_encryption/blob/9e71e2d282ccd106cbe3f5f62ad60abd5d05d072/lib/UserAgentManager.php

from end_to_end_encryption.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.