Comments (3)
If we consider that malloc never fails and that these abort()
are only safekeepers, I would be okay to integrate a pull-request that handle this without aborting, but doing this would be at the lowest priority…
Please open a pull-request if you have a patch that fixes this issue for you.
from libfreefare.
First of all, you handle failure to malloc()
in all other places in the code, just not here. Why do you deviate from your perfectly fine error handling just in this one place? Second, the answer you linked is wrong and dangerous. It's pretty easy to get malloc()
on Linux to fail, contrary to what this answer says. Also, Linux is not the only operating system in the world and malloc()
may fail much more likely on other operating systems.
If you are unable to fix this issue on your own, I can write a patch for you, but you should really fix your own issues.
from libfreefare.
you handle failure to malloc() in all other places in the code, just not here
The code has been written in multiple shots over a long period of time, and while I agree with you that failing gracfuly is ways better than aborting, and consistency accross the code base would be better, the value of such a change is currently low from my point of view (I am not affected by this problem and there are other topics in the nfc-tools which are more important to fix before this kind of problems).
If you are unable to fix this issue on your own, I can write a patch for you, but you should really fix your own issues.
As I said, this is at the lowest priority. I would be happy to merge a pull request that fixes this if you can offer one, or will work on this if somebody can pay for this, but I can't offer another solution ATM due to time.
So, our possibilities are:
- If we receive a pull-request referencing this issue, it will be merged;
- If more people 👍 this issue, we will reopen it and reconsider this;
- If none of the above happen, it is unlikelly to change, sorry.
Thanks!
from libfreefare.
Related Issues (20)
- ARM issue desfire_crc32 wrong direction HOT 3
- Unknown key version - card locked after desfire test HOT 1
- Support for NTAG 424, DESFire Lite, and some limited DESFire EV2 HOT 13
- Why doesn't it support mifare plus? HOT 2
- MIFARE DESFire EV2 fails some unit tests HOT 1
- Cut a 1.0.0 release HOT 6
- Create a 0.4.x branch HOT 4
- Wiki, Website and Forum not available HOT 2
- libnfc.driver.acr122_usb: Command Code verification failed when calling mifare_classic_write() HOT 1
- Wrong implementation for CRC padding in mifare_cryto_postprocess_data
- Specs for setting encrypted transfer modes with DESFire tags HOT 2
- PCSC detection for PN532 board via SPI
- mifare_desfire_get_key_settings() discards encryption type bits HOT 5
- Failure to compile HOT 1
- Just some explanation needed HOT 1
- Why freefare_get_tags() not detect smartphone NFC?
- QUESTION: libfreefare portable to non-android system
- unable to dump application 0x9011f2
- DESFire key diversification - problem with random UID
- JCOB CARD EV3 8k Issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libfreefare.