GithubHelp home page GithubHelp logo

Hardcoded CARD_WIDTH about nfsee HOT 5 OPEN

nfcim avatar nfcim commented on August 22, 2024 1
Hardcoded CARD_WIDTH

from nfsee.

Comments (5)

DawnMagnet avatar DawnMagnet commented on August 22, 2024

May I ask what CARD_WIDTH meas?

from nfsee.

DawnMagnet avatar DawnMagnet commented on August 22, 2024

Do you mean this const double CARD_WIDTH = (240 - 20) * (86.0 / 54) + 20; in nfsee/lib/ui/card_physics.dart

from nfsee.

dangfan avatar dangfan commented on August 22, 2024

CARD_WIDTH means the width of each card shown on the main screen.

from nfsee.

DawnMagnet avatar DawnMagnet commented on August 22, 2024

I nearly get it.Should we dynamically compute it by screen width or something else?

from nfsee.

CircuitCoder avatar CircuitCoder commented on August 22, 2024

@DawnMagnet I suppose we should be able to compute it based on screen width? Maybe we can introduce a max card width computable from screen width?

The more complicated part of the story is that, the height of the card is defined as a fixed ratio of its width. So adjusting card width can also change the amount of vertical screen space occupied by a card, affecting the layout and animation of the card detail fields below the card.

I guess it's not a big problem, but we should be careful about that.

from nfsee.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.