setInput doesn't respect the alias names about spectator

[NetanelBasal]

I trust you to reach a solution and open a PR

[profanis]

Sorry for the delay.
This is the relevant PR #652

[stackblitz]

Start a new pull request in StackBlitz Codeflow.

• stackblitz-starters-vn8kfk (Open reproduction)

[profanis]

How about if we provide a more loose function overload?

https://github.com/ngneat/spectator/blob/master/projects/spectator/src/lib/spectator/spectator.ts#L44

  public setInput(input: string, inputValue: unknown): void;

I think something similar exists also in Angular repo
https://github.com/angular/angular/blob/da906fdafcbb302fa280a162d1c1f04369be2efa/packages/core/src/linker/component_factory.ts#L34

[profanis]

How about if we provide a more loose function overload?

https://github.com/ngneat/spectator/blob/master/projects/spectator/src/lib/spectator/spectator.ts#L44

  public setInput(input: string, inputValue: unknown): void;

I think something similar exists also in Angular repo https://github.com/angular/angular/blob/da906fdafcbb302fa280a162d1c1f04369be2efa/packages/core/src/linker/component_factory.ts#L34

@kfrancois @NetanelBasal what do you think?

[kfrancois]

Hi @profanis! Thank you for logging this issue.

I think what you propose is the best possible option at the moment. Unfortunately, input aliases are defined as string inside the Angular repo:

interface InputOptions<ReadT, WriteT> {
    alias?: string;
    transform?: (v: WriteT) => ReadT;

If this were a generic type (or rather, if alias was generic instead of string), we would at least be able to infer the correct field name and use it for setInput (at least for signal inputs, traditional inputs we wouldn't be able to do anything), but for now it feels safer to lose type info here and go with input: string, inputValue: unknown.

[NetanelBasal]

Can we close it?