Comments (6)
NetanelBasal
commented on June 20, 2024
Do you want to create a PR?
from svg-icon.
Lonli-Lokli
commented on June 20, 2024
How do you think should look like original icon, as a handlebar template?
from svg-icon.
NetanelBasal
commented on June 20, 2024
The issue with your suggestion, in general, is that it will increase the bundle code size because we generate additional components.
from svg-icon.
NetanelBasal
commented on June 20, 2024
In the current implementation we support tree-shaking, so what's the benefit of your suggestion?
from svg-icon.
Lonli-Lokli
commented on June 20, 2024
It allows usage of specific icons - instead of specifying key='leftArrow' we can use LeftArrowIcon, without any registry.
Also it will be safer, now key of svg-icon is string, not the actual icon type
from svg-icon.
NetanelBasal
commented on June 20, 2024
I understand this, but on the other side, it will increase your bundle size. I don't mind leaving this decision to the consumer.
from svg-icon.
Related Issues (20)
- svg-generator doesn't work HOT 3
- Unit tests fail after updating to v5 and v6 HOT 3
- import SvgIconComponent documentation HOT 2
- Add support for getting the raw svg data url
- Add support for stroke color
- Cannot use `SvgIconComponent` in standalone component
- Cannot use strings in the @Input key, only SvgIcons type HOT 2
- SvgIcons definition is overridden in Nx monorepo with several libs HOT 3
- style="color: var(--svg-icon-color)" added even if color == undefined HOT 1
- Svg generator with folders not work properly
- Icon provided at standalone component level is not rendering HOT 3
- Conflict involving icons that share the same name but have different paths (solid/outline). HOT 1
- @ngneat/svg-generator throws error and cannot find module 'svgo' HOT 3
- Type signature errors with `bootstrapModule()` - documentation refers to out of date `bootstrapApplication()` HOT 1
- SVG Icons are generated successfully in serve mode but not in prod mode HOT 4
- key type and name missmatch if icon has _ in filename HOT 13
- Is there a way to keep original colors
- How it differs from Angular Material Icon Registration?
- Let us define our own preserveAspectRatio for SVGs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svg-icon.