GithubHelp home page GithubHelp logo

Comments (6)

 avatar commented on August 26, 2024

This seems to be a specific example of #7.

from line-reader.

scaryguy avatar scaryguy commented on August 26, 2024

Any update or work around on this?

from line-reader.

scharf avatar scharf commented on August 26, 2024

The API is not following the node standard, because it does not use error as first argument in the callback.

from line-reader.

jedwards1211 avatar jedwards1211 commented on August 26, 2024

I was thinking about this, I think there should just be an (error, result) callback after the (line, last) callback in the arguments to eachLine(), plus the other options should be supplied as a hash that comes before this last callback. This callback would be called at the very end of everything. That way the function could be auto-promisified by libraries like bluebird (and the .then() handler could be removed since it doesn't follow any promise standards either). If error was provided as the first argument to the per-line callback, then it couldn't be auto-promisified.

I looks to me like Nick Ewing doesn't intend to actively maintain this...but he has merged PRs somewhat recently.

from line-reader.

nickewing avatar nickewing commented on August 26, 2024

@jedwards1211 You're right, I haven't had time to do fixes myself and I haven't been working with node recently. I am very happy to review and accept PRs however!

from line-reader.

jedwards1211 avatar jedwards1211 commented on August 26, 2024

Yeah, understandable! Well if I find time soon I'll see if I can make a PR for this.

from line-reader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.