GithubHelp home page GithubHelp logo

angular 10+ support about ngx-scroll-to HOT 21 CLOSED

igorlino avatar igorlino commented on May 23, 2024 25
angular 10+ support

from ngx-scroll-to.

Comments (21)

daniel-seitz avatar daniel-seitz commented on May 23, 2024 14

P.S. while you're at it, Angular 11 is out already as well. What about making this package less restrictive and just specify the minimum version to avoid future issues like this. I mean something like:

"peerDependencies": {
    "@angular/common": ">=8.0.0",
    "@angular/core": ">=8.0.0",
    "tslib": "^1.10.0"
  }

Then, when something breaks, we could review this setting.

from ngx-scroll-to.

rafa-suagu avatar rafa-suagu commented on May 23, 2024 7

Hi there, I'm sorry for the delay, we will push the changes to make the warnings away ASAP.

from ngx-scroll-to.

smileLilith avatar smileLilith commented on May 23, 2024 2

PR with the upgrade to Angular v10 #138. Tagging @rafa-as 😄

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024 2

@rafa-as any updates on this? I haven't seen an update in npm...?

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024 2

@Jonnyprof @rafa-as Any chance to get this sorted out?

from ngx-scroll-to.

rafa-suagu avatar rafa-suagu commented on May 23, 2024 2

Angular 13 support it's released and the 14 it's on the way

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024 1

I would also like to see this getting in. Thanks!

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024 1

@nicky-lenaers can you update the dependencies to 11? I've tested this to work with angular 11 as well - I would like to avoid these warnings if possible... pretty please :-)

from ngx-scroll-to.

D-Biela avatar D-Biela commented on May 23, 2024 1

Still not updated... I guess we have to use an other package. I do not want to run npm install/update with the --force flag every time.

from ngx-scroll-to.

csimpi avatar csimpi commented on May 23, 2024 1

ping

from ngx-scroll-to.

tstackhouse avatar tstackhouse commented on May 23, 2024 1

The fork @paulvmoreau/ngx-scroll-to supports Angular 11, however neither supports Angular 12. The latest updates only support 13 and 14, it makes the upgrade path very difficult.

from ngx-scroll-to.

akaustav avatar akaustav commented on May 23, 2024 1

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024

@maintainers, any change to push this forward? it's been open for a long time now. It is currently the last package I get a warning about that is related to angular 12.
Simply change the dependencies to be >= 8.0 and add a note about using at your own risk, that's all, shouldn't take more than a few minutes...
Please, please, please...

from ngx-scroll-to.

rbalet avatar rbalet commented on May 23, 2024

The repo doesn't seem to be maintained anymore....

from ngx-scroll-to.

HarelM avatar HarelM commented on May 23, 2024

Yup, I'll probably copy the files here into my codebase and remove the reference... :-(

from ngx-scroll-to.

igorlino avatar igorlino commented on May 23, 2024

:( Angular 13.1 is out, and same story

from ngx-scroll-to.

josh803316 avatar josh803316 commented on May 23, 2024

👍 Would be nice if this were updated.

npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nicky-lenaers/[email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"13.3.1" from the root project
npm ERR!   peer @angular/common@"^13.0.0 || ^14.0.0-0" from @angular/[email protected]
npm ERR!   node_modules/@angular/cdk
npm ERR!     @angular/cdk@"~13.3.2" from the root project
npm ERR!     peer @angular/cdk@"13.3.2" from @angular/[email protected]
npm ERR!     node_modules/@angular/material
npm ERR!       @angular/material@"~13.3.2" from the root project
npm ERR!   11 more (@angular/fire, @angular/forms, @angular/material, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^8.0.0 || ^9.0.0" from @nicky-lenaers/[email protected]
npm ERR! node_modules/@nicky-lenaers/ngx-scroll-to
npm ERR!   @nicky-lenaers/ngx-scroll-to@"^9.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   peer @angular/common@"^8.0.0 || ^9.0.0" from @nicky-lenaers/[email protected]
npm ERR!   node_modules/@nicky-lenaers/ngx-scroll-to
npm ERR!     @nicky-lenaers/ngx-scroll-to@"^9.0.0" from the root project

from ngx-scroll-to.

igorlino avatar igorlino commented on May 23, 2024

:( Angular 14 is out

from ngx-scroll-to.

sambernet avatar sambernet commented on May 23, 2024

Thanks to @rafa-as and @andreas-aeschlimann there is now some action again on this repo 🎉

To link stuff together, maybe we can rename this issue to Angular 10+ support and close #150 as a duplicate @andreas-aeschlimann ?

Anyway, for anybody interested in the current progress, please also check the discussion in PR #164

from ngx-scroll-to.

andreas-aeschlimann avatar andreas-aeschlimann commented on May 23, 2024

Closing #150 in favor of this.

I hope the PR is resolved soon!

from ngx-scroll-to.

mmicheux avatar mmicheux commented on May 23, 2024

Hi! Can this get Angular 11 support?

from ngx-scroll-to.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.