Comments (21)
P.S. while you're at it, Angular 11 is out already as well. What about making this package less restrictive and just specify the minimum version to avoid future issues like this. I mean something like:
"peerDependencies": {
"@angular/common": ">=8.0.0",
"@angular/core": ">=8.0.0",
"tslib": "^1.10.0"
}
Then, when something breaks, we could review this setting.
from ngx-scroll-to.
Hi there, I'm sorry for the delay, we will push the changes to make the warnings away ASAP.
from ngx-scroll-to.
PR with the upgrade to Angular v10 #138. Tagging @rafa-as 😄
from ngx-scroll-to.
@rafa-as any updates on this? I haven't seen an update in npm...?
from ngx-scroll-to.
@Jonnyprof @rafa-as Any chance to get this sorted out?
from ngx-scroll-to.
Angular 13 support it's released and the 14 it's on the way
from ngx-scroll-to.
I would also like to see this getting in. Thanks!
from ngx-scroll-to.
@nicky-lenaers can you update the dependencies to 11? I've tested this to work with angular 11 as well - I would like to avoid these warnings if possible... pretty please :-)
from ngx-scroll-to.
Still not updated... I guess we have to use an other package. I do not want to run npm install/update with the --force flag every time.
from ngx-scroll-to.
ping
from ngx-scroll-to.
The fork @paulvmoreau/ngx-scroll-to supports Angular 11, however neither supports Angular 12. The latest updates only support 13 and 14, it makes the upgrade path very difficult.
from ngx-scroll-to.
- For those looking for Angular 12 support specifically, I have created a fork at @akaustav/ngx-scroll-to.
- And published the corresponding @akaustav/ngx-scroll-to npm package.
- I have also created a Compatibility Table to document compatibility between specific versions of the package and specific versions of Angular.
from ngx-scroll-to.
@maintainers, any change to push this forward? it's been open for a long time now. It is currently the last package I get a warning about that is related to angular 12.
Simply change the dependencies to be >= 8.0 and add a note about using at your own risk, that's all, shouldn't take more than a few minutes...
Please, please, please...
from ngx-scroll-to.
The repo doesn't seem to be maintained anymore....
from ngx-scroll-to.
Yup, I'll probably copy the files here into my codebase and remove the reference... :-(
from ngx-scroll-to.
:( Angular 13.1 is out, and same story
from ngx-scroll-to.
👍 Would be nice if this were updated.
npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @nicky-lenaers/[email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR! @angular/common@"13.3.1" from the root project
npm ERR! peer @angular/common@"^13.0.0 || ^14.0.0-0" from @angular/[email protected]
npm ERR! node_modules/@angular/cdk
npm ERR! @angular/cdk@"~13.3.2" from the root project
npm ERR! peer @angular/cdk@"13.3.2" from @angular/[email protected]
npm ERR! node_modules/@angular/material
npm ERR! @angular/material@"~13.3.2" from the root project
npm ERR! 11 more (@angular/fire, @angular/forms, @angular/material, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^8.0.0 || ^9.0.0" from @nicky-lenaers/[email protected]
npm ERR! node_modules/@nicky-lenaers/ngx-scroll-to
npm ERR! @nicky-lenaers/ngx-scroll-to@"^9.0.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR! peer @angular/common@"^8.0.0 || ^9.0.0" from @nicky-lenaers/[email protected]
npm ERR! node_modules/@nicky-lenaers/ngx-scroll-to
npm ERR! @nicky-lenaers/ngx-scroll-to@"^9.0.0" from the root project
from ngx-scroll-to.
:( Angular 14 is out
from ngx-scroll-to.
Thanks to @rafa-as and @andreas-aeschlimann there is now some action again on this repo 🎉
To link stuff together, maybe we can rename this issue to Angular 10+ support
and close #150 as a duplicate @andreas-aeschlimann ?
Anyway, for anybody interested in the current progress, please also check the discussion in PR #164
from ngx-scroll-to.
Closing #150 in favor of this.
I hope the PR is resolved soon!
from ngx-scroll-to.
Hi! Can this get Angular 11 support?
from ngx-scroll-to.
Related Issues (20)
- Make compatible with Angular 7 HOT 4
- ScrollTo is not working with body/windows container and target wrapped by a container with relative position HOT 3
- Missing ScrollToEvent class in public_api HOT 2
- Zoom - wrong position. HOT 3
- iOS doesnt scroll, it jumps to the specified div id. HOT 1
- Make compatible with Angular 8 HOT 7
- ISSUE, scroll-to incomplete
- Having issue with Google Chrome
- CI process fails
- Issues with Angular 8 while building. HOT 3
- 9.0.0 release broken in IE11 HOT 3
- How to listen / subscribe to animation finished HOT 2
- Angular 12 Support HOT 3
- Doesn't work on mobile view HOT 1
- Support for Angular 15 HOT 3
- Support for Angular 16 HOT 6
- Support for Angular 16+
- Requesting ability to scroll both up and down, ability to stop animation programmatically, and proper notification when scrolling is complete.
- Support for Angular 17+
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngx-scroll-to.