GithubHelp home page GithubHelp logo

Comments (4)

niclic avatar niclic commented on August 17, 2024 1

However, since I am revising this chart in preparation for migration to the prometheus-community chart repo, I will review the ingress implementation from scratch. I don't think the config in values.yaml is clear enough, and it might be a good idea to upgrade the ingress resource version as well.

from helm-charts.

niclic avatar niclic commented on August 17, 2024

My recollection is using ingress to expose the /metrics endpoint, so the metrics could be viewed in a browser, which is useful for troubleshooting. This requires exposing the webPort of the service, and not the udpPort or tcpPort ports. So, I don't think I experienced the same issue you did.

from helm-charts.

yaron-idan avatar yaron-idan commented on August 17, 2024

That's great to hear, good luck with that!
I've already deployed my own version of the chart with a few modifications, it addresses the way these different protocols are handled. You're welcome to take a look and if you are interested I can open a PR so you can merge them back into your repository.

from helm-charts.

niclic avatar niclic commented on August 17, 2024

Yes, after review, the ingress resource was not properly implemented in this chart. For migration, I considered removing it altogether. However, I have modified it to expose the /metrics endpoint for viewing (or even scraping), which can be useful.

To make this chart expose the tcp and udp endpoints for metrics collection outside a cluster, will require additional work. That can certainly happen, since it does seem to be to be a valid use case. However, the chart will need to support exposing multiple ports, which may require patching of the ingress controller. It's complicated, so probably requires a bit of consideration (e.g. multiple services, etc).

I really appreciate your interest in this and sorry again for the lack of timely feedback. I had an issue with my github notifications.

from helm-charts.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.