Invoke-BuildExec spitting out service principal secret as current directory about invoke-build

[nightroman]

Why $pwd? Well, why not? Using Get-Location may have some advantages (and disadvantages). Just like using $pwd, some advantages and disadvantages.

[nightroman]

exec -echo {...} prints $pwd as cd $pwd, see

Invoke-Build/Invoke-Build.ps1

Line 269 in ccb3839

Write-Build 8 "cd $pwd"

Is it possible that your $pwd contains such a value? If yes then it all works as expected.

If such "echo" is not welcome then do not use this switch with exec.

[nightroman]

Hmm, an idea. Do you by any chance use the PowerShell automatic variable $pwd (current location) as a some sort of password?

https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_automatic_variables?view=powershell-7.3#pwd

[nightroman]

If yes, I'd say it is not a good idea to mess with PS automatic variables, who knows when and how this bites.
But this is up to the author / script, indeed, no problem.

In the meantime I'll think of printing cd $global:pwd to minimize chances of such issues.

[codepic]

Yes, you're right. There was another function within the same module assigning $script:pwd which within a module means module-wide scope.

The $global:pwd sounds good 👍

Question: Why not Get-Location? Because it's isn't available in PowerShell 2.0?

Benefit from Get-Location would be that it's supported by Pester Mock. Not that I can think off the shelf a scenario where one would want to use it...

Describe "Get-Location" {
	Context "Mocking works..." {
		BeforeEach{
			Mock Get-location { return @{ Path = 'D:\' } }
			$script:result = Get-Location
		}
		
		It "should work" {
			$script:result.Path | Should -Be 'D:\'
		}
	}
}

[nightroman]

Done, v5.10.2