Comments (4)
Hey @cnoon, thanks for the quick response! I definitely agree that it should be attached to every LogLevel
, I just didn't want to suggest something so invasive outright :)
I was thinking that since I'm going to make these changes anyway, I could just send you the code to look at. Then, if you think it would be beneficial we could incorporate it, otherwise I'll just keep it for myself. I've only spent about an hour and it's almost done, so I don't think the change will be too time consuming, it's just a lot of lines of code changed.
from willow.
Hi @nsinklier,
This is certainly something we've been experimenting with as well and have decided to place it on top of Willow itself for now. If we wanted to do this directly in Willow, we'd probably want to support file
, function
, line
, and column
in each of the Logger
APIs which would then forward those to the LogWriter
APIs. That would allow writers to decide how to use them if they wanted.
Given the scope of this change, I'm not sure it's something you'd actually like to take on yourself since it would be a MAJOR version change. It's certainly something that we've been noodling on for a while.
Thoughts?
from willow.
I personally think that the position belongs to a log message. Without the position, log messages are only half as valuable. That's why I implemented this feature request and opened a pull request.
from willow.
Hey @cnoon, any plans to merge PR #60 in the next time?
from willow.
Related Issues (19)
- Pictures in the readme.md file perhaps? HOT 5
- Colored Console Output in Xcode 8 HOT 1
- Support of the new Unified Logging and Tracing System for iOS and macOS HOT 2
- Add Logsene / Elasticsearch Writer HOT 1
- Willow 2.0 not available on cocoapods HOT 2
- coloredTimestampConfiguration referenced in Readme but not in code HOT 1
- I have some suggestions HOT 7
- OSLogWriter not compiling on macOS HOT 1
- OSLogWriter sends os logs with same type for both warn and error levels HOT 9
- Application ends before all logs are printed to console using async execution method HOT 1
- Vulnerability to deadlocks with synchronous execution method HOT 1
- Impossible to compile on linux HOT 1
- Managing os_log <private> logging HOT 1
- Feature request: Linux support
- Is this library still maintained? HOT 1
- Type not displayed in Console output on Mac for OSLogWriter
- SPM Package via Fastlane in Xcode does not work with Willow HOT 1
- Swift 6 - Concurrency
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from willow.