set_fen does not yet check for chess position legality about python-chess

[sshivaji]

Never mind, looks like calling status() after setting fen does the trick, might be worth making this happen by default

[niklasf]

Yeah, error handling can sometimes be a difficult thing to get right.

It was easier not to automatically check the status after set_fen, because then it is very simple to keep the guarantee, that set_fen does not leave the board in a half updated state.

For example:

board = chess.Bitboard()
try:
    board.set_fen("syntactically-invalid-fen")
except:
    # Now the board is guaranteed to not have changed
    pass

I'll keep this issue to look into this again sometime.

[sshivaji]

I also like that set_fen allows you to setup a position partially (useful
for doing setup board). Maybe a separate process_fen(fen) method might be
useful. This method can throw exceptions if there is something wrong.

This method might be eaiser than set_fen and then checking status() for any
problems.

On Mon, Nov 24, 2014 at 8:43 AM, Niklas Fiekas [email protected]
wrote:

Yeah, error handling can sometimes be a difficult thing to get right.

It was easier not to automatically check the status after set_fen, because
then it is very simple to keep the guarantee, that set_fen does not leave
the board in a half updated state.

For example:

board = chess.Bitboard()
try:
board.set_fen("invalid-fen")
except:
# Now the board is guaranteed to not have changed
pass

I'll keep this issue to look into this again sometime.

—
Reply to this email directly or view it on GitHub
#16 (comment).

[sshivaji]

Will close issue as there are more important things to address