Compatibility with Backbone 0.9.10? about backbone.dualstorage

[nilbus]

Thanks @evantishuk, I'll take a look.

[nilbus]

Yes, there are definitely callback issues with the 0.9.10 changes, and maybe 0.9.9 too, even though the tests pass with 0.9.9 because of the tests' assumptions around Backbone not changing its API.

The discussion in jeromegn/Backbone.localStorage#63 makes it seem like 0.9.9 and 0.9.10 each send different callback arguments from the previous versions.

dualStorage is not currently consistent with the arguments it sends to its callbacks, varying on the method and storage backend. I think the way forward is to maintain compatibility with older versions of backbone and to follow Backbone and standardize the callback arguments this library sends back.

[nilbus]

1.0.0 just came out. Let's shoot for compatibility with 1.0.0 and the earlier versions of backbone that we already support.

[evantishuk]

Yeah, good policy. Would not be surprised if compatibility with 1.0.0 will also bring it into line with 0.9.9 and 0.9.10 as well--possibly fewer version checks (a la https://github.com/phoey/Backbone.localStorage/commit/bd34c367442f6854c0d5664425ec04c8108a69fe).

[nilbus]

@globexdesigns Backbone 0.9.2 is bundled with Backbone.dualStorage in lib/

[nilbus]

I examined the callback code for 0.9.2, 0.9.9, 0.9.10, and 1.0.0. These are the changes:

• 0.9.2 starts with remote methods such as fetch, save, etc. that send the arguments (model, resp) to callbacks, and accept the standard $.ajax parameters (data, textStatus, jqXHR)/(jqXHR, textStatus, errorThrown) in its callbacks from sync.
• 0.9.9 sends a 3rd options argument to the success and error callbacks given to remote methods like fetch. This doesn't affect us since we do not implement the remote methods like fetch.
• 0.9.10 changes sync so that it calls the fetch(etc.) success/error callbacks with (model, resp/xhr, options), which allows those methods to call their callbacks with the same arguments. Sync gets resp/xhr from the first parameter in the $.ajax callback.
• 1.0.0 changes sync back to how it was in 0.9.2, passing the $.sync callback parameters directly into the fetch(etc.) callbacks. However now the fetch(etc.) callbacks accept only the first argument (resp/xhr). This means that Backbone.sync (and its substitutes) no longer have have the responsibility of converting the $.ajax callback params to the new 0.9.10 fetch callback args. Since sync sends the same first argument again that 0.9.2 and earlier expected in the remote methods, it's much more backward compatible than 0.9.10 was.

[nilbus]

Thanks @evantishuk for reporting this

[evantishuk]

Don't thank me, you did all the work. Thanks for addressing it. I like your solution.

[nilbus]

This code snippet causes the fix to fail on Backbone 0.9.10:

var Model = Backbone.Model.extend({
    url: '/test',
    remote: false,
    local: true,
    success: function() {},
    error: function() {}
});

var model = new Model({name: 'test'});
model.save();
model.save({name: 'asd'});
model.save({name: 'asd3'});
model.save({name: '234234'});
console.log(model.attributes);

TypeError: Cannot call method 'call' of undefined at: