Comments (3)
While looking at the code, I have found out that there are two issues basically.
In joinPath(".", "a")
and similar cases, the path becomes "."
after first addNormalizePath
and second addNormalizePath
doesn't remove it. In test cases this one is called "controversial" because of how paths to executables behave on Unix systems:
Lines 590 to 594 in 0b5a938
Retaining this behavior might be good to prevent older programs from breaking, but it starts to look much weirder in case of
joinPath("b", "..", "a")
or joinPath(".", "..")
, so probably worth either fixing or documenting.
The second part is less controversial and more looks like a bug. The problem is in the line
Line 75 in 0b5a938
This is not the correct way to check if it's the first component of the path, as
state == 0
holds also for such paths as .
or ../..
. Thus, when handling joinPath("x/..", "/a", "/b", "../../..")
it starts to think at some point that the path is absolute, because it receives "/"
from PathIter
. Though, by coincidence and only because the .
is not removed because of the first issue, it seems that such incorrect state doesn't lead to wrong results (or at least I haven't been able to found the failing case).from nim.
But ./a
is not the same as a
. 🤔
from nim.
But ./a is not the same as a. 🤔
Well, but
import std/[os, paths]
echo normalizedPath("./a")
echo "./a".Path == "a".Path
prints
a
true
And the documentation promises that joinPath
Nim/lib/std/private/ospaths2.nim
Lines 96 to 98 in 0b5a938
but
./a
is obviously not normalized.from nim.
Related Issues (20)
- Using waitForExit with timeout from multiple threads simultaneously hangs HOT 1
- Cyclic proc calls causes infinite memory usage HOT 12
- Custom iterator is not found if used in template function, if used from a third file HOT 1
- bisecting 2.2.0 rc1 HOT 17
- cursor optimizer doesn't understand that distinct cstring can be an owning type
- Cross compilation with mingw for cpu=i386 from linux/macos fails with time_t bug HOT 2
- Type error when sink added to parameters HOT 2
- Nim `devel` nightly `i386` build failing HOT 1
- `koch pdf` produces a warning about unknown substitution 'nimversion'
- `nim gendepend` does not work with var-less destructors
- When JS, operations on pointer casted from ref object raises Runtime-Errors
- Regression - cannot instantiate Maybe generic arguments are missing HOT 5
- Identifier expected or compiler segfault with templates over generic type in type section HOT 3
- Nested generic/static parameter: undeclared identifier in typesections HOT 2
- 2.2.0 rc1 regression with cdecl functions
- Warnings missing when compiling the same file twice HOT 4
- `genericsOpenSym` not working when additional generally non-matching symbol with same name is present HOT 2
- nimsuggest crashes when using `--mm:arc/orc` and if an object that contains `string` or `seq` is constructed HOT 2
- ARC hooks missing when sinking generic typeclass HOT 3
- Generic concepts not compatible with openarray HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nim.