Comments (6)
Seems like maybe one is adding a trailing new line and the other isn't?
from zip.
This happens because the stdlib FileStream
's atEnd
peeks to check for EOF, whereas GzFileStream
's one uses gzeof
which checks for a flag set after a failed read. To make GzFileStream
's behavior consistent with FileStream
I had to change types on some procs in the interface module, since they were incorrect. I'm guessing this calls for upping the version?
from zip.
Yep :)
from zip.
Thank you for fixing this!
from zip.
I wanted to make a PR for this, but then I realized that the zlib.nim
wrapper has wrong types in a ton of places! E.g. it aliases Ulong
as int
, but in zlib.h
it's, unsurprisingly, typedef'd to unsigned long
, it uses as int
instead of cuint
for the length for gzread
and gzwrite
, etc. Also, the code uses int32
all over the place, but I suppose it technically should be using cint
s.
I guess I should make a new issue and all that should be fixed up, but should include it all in one PR or split it?
from zip.
Most of these typing issues are OK in my book for reasons I don't want to go into, but sure fix them in a separate PR.
from zip.
Related Issues (20)
- Documentation and examples
- addFile StringStream fails on Windows HOT 1
- ZIP Password HOT 1
- Error: ambiguous identifier: 'Time' HOT 3
- allow passing flags to zip_open via open HOT 5
- Not compiling on windows HOT 3
- windows vs linux inconsistency HOT 7
- please update libzip version to 1.6.1
- fixed: zlib version mismatch! [ZlibStreamError] HOT 4
- Directory traversal vulnerability from libzip HOT 15
- Tag a new release of zip
- Update to newer zlib, add new functions
- Incorrect version check in deflateInit, inflateInit, etc.
- Unable to import module HOT 2
- Issue trying to read stats on file in zip files HOT 1
- zip_open_from_source() & zip_source_buffer_create() not defined in libzip_all.c
- Issues cross-compiling with MinGW HOT 1
- libzip.dylib not found when installed via homebrew on Mac OSX HOT 1
- Cannot write multiple files to same zip archive
- zlib.h: No such file or directory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zip.