GithubHelp home page GithubHelp logo

GZFileStream atEnd too late about zip HOT 6 CLOSED

nim-lang avatar nim-lang commented on August 25, 2024
GZFileStream atEnd too late

from zip.

Comments (6)

dom96 avatar dom96 commented on August 25, 2024

Seems like maybe one is adding a trailing new line and the other isn't?

from zip.

recloser avatar recloser commented on August 25, 2024

This happens because the stdlib FileStream's atEnd peeks to check for EOF, whereas GzFileStream's one uses gzeof which checks for a flag set after a failed read. To make GzFileStream's behavior consistent with FileStream I had to change types on some procs in the interface module, since they were incorrect. I'm guessing this calls for upping the version?

from zip.

dom96 avatar dom96 commented on August 25, 2024

Yep :)

from zip.

dom96 avatar dom96 commented on August 25, 2024

Thank you for fixing this!

from zip.

recloser avatar recloser commented on August 25, 2024

I wanted to make a PR for this, but then I realized that the zlib.nim wrapper has wrong types in a ton of places! E.g. it aliases Ulong as int, but in zlib.h it's, unsurprisingly, typedef'd to unsigned long, it uses as int instead of cuint for the length for gzread and gzwrite, etc. Also, the code uses int32 all over the place, but I suppose it technically should be using cints.
I guess I should make a new issue and all that should be fixed up, but should include it all in one PR or split it?

from zip.

Araq avatar Araq commented on August 25, 2024

Most of these typing issues are OK in my book for reasons I don't want to go into, but sure fix them in a separate PR.

from zip.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.