Comments (4)
Thanks for pointing this out, this should never happen and if it does then it is indeed a problem.
The exception handling in PublishImpl
is there to ensure that a thrown exception by a subscriber's handler does not mess up all the other handlers and it is not there to filter the subscribers.
Let me write some tests to try to reproduce this.
from easy.messagehub.
Thanks! I've fixed it locally by making this change in the Subscribe method, testing that msg is of type TMsg before doing the explicit cast:
_subscriptions.Add(new Subscription(
token,
new Handler<TMsgBase>(msg => { if (msg is TMsg) handler.Handle((TMsg)msg); } )));
from easy.messagehub.
Yes you can use that as a temp fix however it is still throwing some errors. In the UsageExample
tests if you subscribe to the OnError
you will see the errors.
Actually you raising this issue has prompted me to re-visit some of the decisions I had made, I have now modified and improved the API slightly and also improved the way I subscribe and publish to both fix your issue as well as improving the throughput.
I am testing it at the moment and will be pushing it shortly.
from easy.messagehub.
Verified. Thanks for the quick turnaround!
from easy.messagehub.
Related Issues (20)
- Registering IMessageHub with MessageHub HOT 1
- Subscribing a runtime type HOT 5
- Subscriber is receiving 3 messages when publisher is only sending 1 HOT 7
- Publish & Subscribe from different Project? HOT 2
- Non-singleton instances HOT 8
- Sometimes Unsubscribe method hangs HOT 6
- How to setup one Server with Many cleints between ASP Core web and .net Console service HOT 1
- System.ObjectDisposedException: ThreadLocal object has been deleted. HOT 1
- NuGet package?
- Async handlers HOT 2
- Get MessageHub to play nicely with Autofac in a web application HOT 1
- Conditional subscription HOT 6
- Unflexible detection of the given type HOT 4
- Support for async actions HOT 2
- Add an async publisher HOT 4
- Available for dotnet core? HOT 2
- Add async version HOT 6
- MessageHub is holding objects in Memory HOT 18
- UnSubscribe method causes ArgumentNullException HOT 1
- Publish and subscribe from different threads HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from easy.messagehub.