Comments (10)
Full logs are now available.
from ofborg.
Also the full log would be interesting in case of a failure.
from ofborg.
BTW I have Mac sandboxing instructions at https://github.com/grahamc/ofborg/wiki/Operating-a-Builder#macs-and-sandboxing now
from ofborg.
Many of the builders are now streaming full logs back to the server. This is configurable per builder, so some builds will still not provide full logs (https://github.com/NixOS/ofborg/blob/released/ofborg/src/config.rs#L27, https://github.com/NixOS/ofborg/blob/released/ofborg/src/tasks/build.rs#L275)
- It is possible to see a build's logs while they happen by viewing: https://nix.samueldr.com/temp/?key=nixos/nixpkgs.12345 where
12345
is the PR number. - This live-viewer will load scroll-back from the log server, for example: https://logs.nix.gsc.io/logs/nixos/nixpkgs.34107/7db796d3-4da3-4ac5-bc31-55655a2a6ecb but only if you load the log viewer while the build runs.
- The log server exposes an "API" for enumerating attempt logs: https://logs.nix.gsc.io/logs/nixos/nixpkgs.34107 and soon the log viewer will also be using this API (samueldr/ofborg-viewer#2) so you can reload the log viewer page long after the build has finished and see the logs.
Once part 3 is done, I'll automatically provide links to the build output on a PR when the bot is called.
I have to say, a huge thank you to @samueldr for implementing this log viewer for me -- you have been a tremendous help.
from ofborg.
I'm a bit anxious about this, given that they're running on random computers. I'm somewhat worried about giving up too much information, as it could be used maliciously. Thoughts?
from ofborg.
People shouldn't run these without nix sandboxing. Otherwise I can't see any risks directly, but I haven't given it too much thought so far.
from ofborg.
from ofborg.
From a security perspective, how does a shorter log help from preventing confidential information?
from ofborg.
Actually sandboxing works fine with 1.12 locally now.
from ofborg.
Going back to the original key point of this issue:
It would probably be nicer to have build status of explicit runs in the CI box as well (like the eval checks), especially as more platforms are planned.
I don't want to do this, because the green check should be sacred and a "sure thing" for any valid PR. Any potential for unnecessarily causing it to go to a red X should be avoided. This is to make the green check be a strong promise that the code is good, and a red X a guarantee that something is wrong.
Right now, we can't make that promise / guarantee due to periodic issues with aarch64 support or darwin sandboxing. Failed build results still require examination to determine if they're valid issues or not.
from ofborg.
Related Issues (20)
- Always evaluate with `config.allowAliases = false` to avoid deprecation warning errors HOT 2
- python3Packages are not built automatically HOT 4
- Testing functions with "passthru" tests.
- `ofborg-eval-check-meta` does not check `meta.hydraPlatforms` properly HOT 3
- aarch64 community box dropping connection to AMQP host
- ofborg-eval-lib-tests sometimes fails at coreutils tests/du/basic HOT 2
- Waiting to run this check... cool. now what? HOT 4
- ofborg should be able to treat aarch64-darwin as x86_64-darwin for builds
- switch hubcap away from fork HOT 2
- Wrong maintainer request HOT 1
- `@ofborg test installer` did not run installer tests, yet succeeded HOT 2
- OfBorg doesn't fail upon encountering an evaluation error for a newly added package HOT 1
- Eval tests should be executed with the lowest supported Nix version (2.3) HOT 3
- vscode label is not automatically set yet HOT 5
- Rebuild labels are wrong for limited platforms
- dead grafana link in project description HOT 2
- PR check doesn't fail even if all `passthru.tests` fail HOT 5
- do the `check-meta` last instead of first
- use `nix build -f .` instead of `nix-build` for better logs HOT 1
- maintainers detected but not pinged? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofborg.