GithubHelp home page GithubHelp logo

visual presentation of builds about ofborg HOT 10 CLOSED

nixos avatar nixos commented on July 28, 2024
visual presentation of builds

from ofborg.

Comments (10)

grahamc avatar grahamc commented on July 28, 2024 2

Full logs are now available.

from ofborg.

Mic92 avatar Mic92 commented on July 28, 2024 1

Also the full log would be interesting in case of a failure.

from ofborg.

grahamc avatar grahamc commented on July 28, 2024 1

BTW I have Mac sandboxing instructions at https://github.com/grahamc/ofborg/wiki/Operating-a-Builder#macs-and-sandboxing now

from ofborg.

grahamc avatar grahamc commented on July 28, 2024 1

Many of the builders are now streaming full logs back to the server. This is configurable per builder, so some builds will still not provide full logs (https://github.com/NixOS/ofborg/blob/released/ofborg/src/config.rs#L27, https://github.com/NixOS/ofborg/blob/released/ofborg/src/tasks/build.rs#L275)

  1. It is possible to see a build's logs while they happen by viewing: https://nix.samueldr.com/temp/?key=nixos/nixpkgs.12345 where 12345 is the PR number.
  2. This live-viewer will load scroll-back from the log server, for example: https://logs.nix.gsc.io/logs/nixos/nixpkgs.34107/7db796d3-4da3-4ac5-bc31-55655a2a6ecb but only if you load the log viewer while the build runs.
  3. The log server exposes an "API" for enumerating attempt logs: https://logs.nix.gsc.io/logs/nixos/nixpkgs.34107 and soon the log viewer will also be using this API (samueldr/ofborg-viewer#2) so you can reload the log viewer page long after the build has finished and see the logs.

Once part 3 is done, I'll automatically provide links to the build output on a PR when the bot is called.

I have to say, a huge thank you to @samueldr for implementing this log viewer for me -- you have been a tremendous help.

from ofborg.

grahamc avatar grahamc commented on July 28, 2024

I'm a bit anxious about this, given that they're running on random computers. I'm somewhat worried about giving up too much information, as it could be used maliciously. Thoughts?

from ofborg.

vcunat avatar vcunat commented on July 28, 2024

People shouldn't run these without nix sandboxing. Otherwise I can't see any risks directly, but I haven't given it too much thought so far.

from ofborg.

grahamc avatar grahamc commented on July 28, 2024

from ofborg.

Mic92 avatar Mic92 commented on July 28, 2024

From a security perspective, how does a shorter log help from preventing confidential information?

from ofborg.

LnL7 avatar LnL7 commented on July 28, 2024

Actually sandboxing works fine with 1.12 locally now.

from ofborg.

grahamc avatar grahamc commented on July 28, 2024

Going back to the original key point of this issue:

It would probably be nicer to have build status of explicit runs in the CI box as well (like the eval checks), especially as more platforms are planned.

I don't want to do this, because the green check should be sacred and a "sure thing" for any valid PR. Any potential for unnecessarily causing it to go to a red X should be avoided. This is to make the green check be a strong promise that the code is good, and a red X a guarantee that something is wrong.

Right now, we can't make that promise / guarantee due to periodic issues with aarch64 support or darwin sandboxing. Failed build results still require examination to determine if they're valid issues or not.

from ofborg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.