Comments (3)
As I understand some of the functions will be just passing arguments to the wrapped functions without any change?
Yes, we're "guaranteeing" that all functions follow the rules set in our guidelines, but if core PHP functions already do, we're simply calling them without intervening in any way.
Second question - should we put functions under core NS? It would make sense if we'd like to add wrappers for extensions (eg php\mysql\connect / php\mysql\mysql_connect)?
IMHO, neither php\mysql\connect
nor php\mysql\mysql_connect
. I think that for a developer whose been using MySQL functions like mysql_query
, mysql_connect
the best, most intuitive thing would be to find their equivalents in \phpsane\mysql_query
and \phpsane\mysql_connect
.
Good idea. Also it would be good to add those issues to the milestone.
Yup, I'm adding all functions and then I'll edit them all at once. Saves time :-)
from zubr.
We would have to support all functions under "Core"
As I understand some of the functions will be just passing arguments to the wrapped functions without any change?
Second question - should we put functions under core
NS? It would make sense if we'd like to add wrappers for extensions (eg php\mysql\connect
/ php\mysql\mysql_connect
)?
I'm adding each function as an issue, so that whoever implements it can reference the issue while committing or doing pull requests.
Good idea. Also it would be good to add those issues to the milestone.
I think we should do 1 function per commit/request, referencing the issue.
+1
from zubr.
Closing this as workflow is pretty clear by now.
from zubr.
Related Issues (20)
- Double-check Composer file
- `array_column` PSR2 errors
- Doc block guidelines HOT 7
- Slack
- Zubr isn't bundled with PHP HOT 4
- Implement validator tool HOT 2
- Automate adding functions and tests HOT 11
- xxxx
- Add test for array_count_values()
- array_change_key_case() has wrong default value
- array_change_key_case() has wrong doc format
- array_chunk() has wrong doc format
- array_chunk() has wrong doc format HOT 1
- array_combine() has wrong doc format
- Add test for array_fill_keys()
- Add test for array_fill()
- Add test for array_flip()
- Add test for array_keys()
- Remove dist folder? HOT 6
- Add a performance readme entry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zubr.