nmaguirre / eiffel-2048 Goto Github PK

The method returns true if a given integer value is a power of two.

The constructor that creates a controller using a board as an argument is not implemented

Features and corresponding acceptance tests for basic game movements must be created. Features description must match Gherkin's syntax; corresponding acceptance tests (in the syntax of Eiffel's Autotest) must also be provided. This issue corresponds solely to the movement to up.

Change the feature "get_value" to obsolete and put a coment with the correct usage.

The tests should check that this method only allow store in the cell a value which is a power of two distinct to 1 or is 0.

Features and corresponding acceptance tests for basic game movements must be created. Features description must match Gherkin's syntax; corresponding acceptance tests (in the syntax of Eiffel's Autotest) must also be provided. This issue corresponds solely to the movement to the left.

BOARD_2048 does not compile. Syntax error at line 26 (make ... is).

Method that set 2 in board in random position

Missing class CONTROLLER_2048. This class must be created, initially only with routines up, down, left and right (commands with no parameters).

The constructor that creates an empty board (for testing purposes) is not implemented.

Features and corresponding acceptance tests for basic game initialisation must be created. Features description must match Gherkin's syntax; corresponding acceptance tests (in the syntax of Eiffel's Autotest) must also be provided.

Features and corresponding acceptance tests for basic game movements must be created. Features description must match Gherkin's syntax; corresponding acceptance tests (in the syntax of Eiffel's Autotest) must also be provided. This issue corresponds solely to the movement to down.

This features hasn't contracts.

All available cells.

The mothod set_value in class CELL_2048 has not been implemented. This method update the value of a cell with a given value.

Class CELL_2048 hasn't contructors. The constructor should be implemented with respectives tests.

Class NEW_TEST_SET's name is inadequate. It does not indicate clearly its purpose nor what it contains.

Class CELL_2048 has an empty implementation. A proper data structure to capture the cell's state must be defined, and appropriate routines to access and query the state.

According to our basic design, APP_2048 manages a CONTROLLER_2048 instance. This is missing in the implementation.

A separate cluster, for the test sets, must be created, to have files better organised.

Features and corresponding acceptance tests for basic game movements must be created. Features description must match Gherkin's syntax; corresponding acceptance tests (in the syntax of Eiffel's Autotest) must also be provided. This issue corresponds solely to the movement to the right.

Class APPLICATION should be renamed to something like APP_2048.

According to our basic design, class CONTROLLER_2048 should have an attribute of class BOARD_2048.

This test class for the class BOARD_2048, this check all features of the class

End of class missing. Class does not compile. I'm assigning this issue to nico88 (responsible according to Git).

The board is always 4x4, so keeping track of those values is innecessary. Removing this will break the tests, so I leave this issue to those who wrote the test in TEST_BOARD_2048 so they can change their assertions acordingly.

missing contracts of set_cell feature in the BOARD_2048 class and check the ensure clausule of feature make, adding element /= Void

Creation section in class BOARD_2048 is defined using obsolete keyword 'creation'. It must be replaced by 'create'. I'm assigning this issue to nico88, who according to Git is who introduced it.

The routine that returns the value of the cell is missing.

The representation of BOARD_2048.elements should be through a 2-dimensional array, instead of an array of arrays.

Class BOARD_2048 hasn't contructor. The constructor should be implemented.

Routine make in class CELL_2048 is not implemented. This routine must be implemented, possibly equipped with a corresponding contract (pre and postcondition). This issue also includes the definition of tests to exercise this routine, that must comply with statement coverage.

Auxiliary routines, if necessary, must be private. Tests must be given clear names that illustrate what is being measured. Tests for this routine must be put into folder/cluster tests/cell_2048/make_at_cell_2048.e

is_available means that the cell contains zero.

There are two folders in the repository that have nothing to do with the development. Please remove these.

Class CONTROLLER_2048 has an empty implementation. This class must have the control of the board of the game and methods capables of representing the moves (up, down, right or left) on the board.

This class can have an invariant to check the correct implementation of this.

The method set_value in class CELL_2048 has not contracts. They should not allow change the value of a cell with an integer which isn't a power of two or is 1.