Invalid Date about communitymission-progress-viewer

[Khaoz-Topsy]

Great, another breaks in one browser and not the other 😂. I wonder if this is from me updating the dependencies or if it has been like this for a while 🤔

[Lenni009]

Why do we need that dayjs lib anyway? Can the native browser date API not do something this lib can?

[Lenni009]

There's also some invalid dates on Chrome, but there's more of them on Firefox.

If I know the requirements I could probably write up some code for time formatting which you could then implement here. Or maybe I can even fix the bug myself in the code, but I need to know what the expected format and the original purpose of this dayjs library is.

[Khaoz-Topsy]

Interesting, I don't see any invalid dates in chrome

The date format (in the incident section) is dependent on whether or not there should be a time displayed. So either a long time (YYYY-MM-DD HH:mm) if the time is known or just a short date (YYYY-MM-DD) if it was a whole day issue. In other places the date format is different, just because of limited space 😅. I am pretty sure that I used dayJS just because I was lazy, looks like only the formatDate, addDays and dateIsBefore functions are used. So if you rewrite them (in the helper/dateHelper.ts file), then dayJS can easily be removed 😋

I think the bug comes from the .toLocaleString() method. I used it to represent the UTC date from the back-end into time that is in the user's timezone. Your system's date format is probably different to mine, which is probably slightly different between Chrome and Firefox 🤔

[Lenni009]

Maybe because our browsers are set to different languages. Testing this stuff is really hard, since it can work fine in one language, but break for another (like in this case, or for the UD22 website I made last year)

[Khaoz-Topsy]

Yeah, I need to move away from parsing the dates 🤔. It was just so much easier to read than using the Date.UTC() 😅

[Khaoz-Topsy]

And this is probably not helping 😂